Fix the bug that checkpoint saving.#134
Open
qing-yuan233 wants to merge 2 commits intoTencent:mainfrom
Open
Conversation
added 2 commits
December 27, 2024 10:38
…l steps cannot be divided evenly by save_checkpoint_steps.
…l steps cannot be divided evenly by save_checkpoint_steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug that the final checkpoint will not be saved when the total steps cannot be divided evenly by save_checkpoint_steps.
Since the number of total steps needs to be manually calculated and set according to the number of epochs, the sample size, the batch size and the number of workers, it is highly likely that the value of steps is not a perfect integer and may not meet the requirements for saving all checkpoints. Therefore, this fix is necessary.