Maps Raster getting the Coordinate from the orignal raster #109
Open
AM1729 wants to merge 2 commits into
Open
Conversation
moovida
reviewed
Jun 19, 2026
| if (isContained(c, r)) { | ||
| Coordinate coordinate = getWorld(c, r); | ||
| double otherRasterValue = otherRaster.getValue(coordinate); | ||
| Coordinate otherRasterCoordinate =otherRaster.getWorld(c,r); |
Member
There was a problem hiding this comment.
@AM1729 , this needs to be getWorld only, else it will not pick the right col/row pair. The idea is that we need to get the world coordinate of the final raster, so that we can then get the value in that coordinate in the otherRaster. Potentially the col/row that you ask for might not exists in the otherRaster.
I am not sure what issue you are trying to solve, but this is wrong:
Coordinate otherRasterCoordinate =otherRaster.getWorld(c,r);
Conceptually we always need to switch to the world space to get the values from different rasters if they have different gridgeometries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues where the projection itself doesn't change but Axis Order changes, for instance the outRaster initialized with the general CRS object with HMCRSRegistry.Instance.getCrs(code); and we need to map it with another Raster of the same projection but with different Axis order.