feat: add OAuth 2.0 login/Signup with Google and GitHub#151
Open
vd77-1 wants to merge 3 commits into
Open
Conversation
Contributor
|
@vd77-1 is attempting to deploy a commit to the Sameer's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Hi @vd77-1! This is a fantastic implementation of OAuth 2.0. Adding Google and GitHub login will significantly improve our onboarding flow. However, there is a major technical blocker: we just merged PR #122 (Secure Dual-Token Auth), which moved our authentication to an httpOnly cookie system and removed the use of localStorage for tokens. Please rebase your branch on the latest 'main' and update your OAuth flow:
Once the OAuth flow is integrated with our new secure token architecture, I'll be happy to merge this milestone! |
Contributor
Author
|
Ok ,I will update you soon with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign up page

Log in page
