security: enforce room socket membership#200
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Sameer's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
roomId/guestIdpayloads. Guests can only join the room encoded in their token, room messages require membership, guest removal requires the room host, and Pomodoro room control is also host-gated.🔗 Related Issues
✅ Checklist
📸 Screenshots (if applicable)
Not applicable; backend socket authorization change.
💬 Notes for Reviewers
This keeps the frontend event payloads unchanged and rejects unauthorized socket events with a
roomErrorevent, so clients can add UI handling without changing the security boundary.🧪 How to Test This PR
Local result: backend suite passed with 14 test files and 77 tests.
📦 Tech Stack