This repository was archived by the owner on Dec 24, 2024. It is now read-only.
Detect navigation instead of infinite setInterval() loop#551
Open
CatPieLeaf wants to merge 2 commits intoTheRealJoelmatic:mainfrom
Open
Detect navigation instead of infinite setInterval() loop#551CatPieLeaf wants to merge 2 commits intoTheRealJoelmatic:mainfrom
CatPieLeaf wants to merge 2 commits intoTheRealJoelmatic:mainfrom
Conversation
CatPieLeaf
changed the title
CatPieLeaf
force-pushed
the
main
branch
2 times, most recently
from
1019090 to
b391d37
Compare
CatPieLeaf
force-pushed
the
main
branch
4 times, most recently
from
ea63a3f to
913c133
Compare
|
Thanks, this solved other issues as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces setInterval() with three event listeners for attempting to swap players only once the user navigates through the page, instead of throwing multiple attempts every second and causing performance issues.