chore(android): update UI controller according to media3 by seyedmostafahasani · Pull Request #3914 · TheWidlarzGroup/react-native-video

seyedmostafahasani · 2024-06-14T23:37:34Z

Summary

Upgrade player UI to align with media3 demo app

Motivation

Using the native controller to close these issues. (#4019, #3301, #3232, #2599, #4043)

Changes

Test plan

freeboub

It looks like you didn't merge conflicts correctly (around drm props and allowchunklesspreparation. Can you please check that ?
I would like to test it afterward

bulkinav · 2024-06-15T14:42:31Z

Hi @seyedmostafahasani. Can you also add a screenshot of the new UI here? I would like to see what it looks like now )

seyedmostafahasani · 2024-06-16T21:48:30Z

Hi @seyedmostafahasani. Can you also add a screenshot of the new UI here? I would like to see what it looks like now )

@bulkinav thanks for your suggestion. I think it is better to implement the basics of the UI first, then we can implement the screenshot feature in the future in a new PR.
@freeboub what do you think?

seyedmostafahasani · 2024-06-16T21:51:37Z

@freeboub I think we can remove the fullscreen prop in V7. The user can handle fullscreen mode with the setFullScreen method, so we don’t need an additional prop like fullscreen. What is your opinion?

android/src/main/java/com/brentvatne/common/api/Source.kt

docs/pages/component/props.mdx

android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.java

seyedmostafahasani · 2024-06-18T10:24:33Z

@freeboub, if everything works correctly, please don’t merge this branch to master yet. First, let me remove the additional code, then we can merge this branch to master.

seyedmostafahasani · 2024-06-20T15:16:59Z

@freeboub, did you have enough time to test this PR?

ashnfb · 2024-06-20T20:51:44Z

I've tried this version of UI with a video that has captions and multiple audio options
https://bitmovin-a.akamaihd.net/content/sintel/hls/playlist.m3u8

Does the new UI have the ability to show a textTracks selection menu? I could not see a way to turn on / off captions

The audio selection menu also appears buggy, as it repeats the options twice

seyedmostafahasani · 2024-06-21T07:43:52Z

I've tried this version of UI with a video that has captions and multiple audio options https://bitmovin-a.akamaihd.net/content/sintel/hls/playlist.m3u8

Does the new UI have the ability to show a textTracks selection menu? I could not see a way to turn on / off captions

The audio selection menu also appears buggy, as it repeats the options twice

@ashnfb Yeah, it's possible to show the caption button in the new UI. I added it. Please check it out.

seyedmostafahasani · 2024-06-21T08:03:51Z

@ashnfb regarding the audio selection menu, I think this URL has an issue: https://bitmovin-a.akamaihd.net/content/sintel/hls/playlist.m3u8. I've tested it with other URLs, as shown below, and the audio menu works correctly.

freeboub · 2024-06-21T09:53:09Z

Just tested, I found 2 issues fo now:

in the sample app, the controls are displayed by default even if controls={false} by default
in the sample app, when I go to "no view" item and then channel up to 'another live sample', the video shows a big resizing glitch

JerakRus · 2024-08-16T09:40:53Z

I tested it and now it works, thanks for the work done!

seyedmostafahasani · 2024-08-21T14:04:55Z

@freeboub @KrzysztofMoch
Please review this PR, as it will allow us to close some issues after merging.

# Conflicts: # android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt # android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java # docs/pages/component/props.mdx

# Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java

freeboub · 2024-09-04T15:19:52Z

@seyedmostafahasani I would like to focus on this PR for my next task, can you please remerge with master ?
I would like to handle open PRs before doing anything else :)

seyedmostafahasani · 2024-09-04T17:10:15Z

@seyedmostafahasani I would like to focus on this PR for my next task, can you please remerge with master ? I would like to handle open PRs before doing anything else :)

Thanks @freeboub .
For sure! I will do it.

# Conflicts: # android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt # android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.kt # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java # docs/pages/component/props.mdx # src/specs/VideoNativeComponent.ts # src/types/video.ts

seyedmostafahasani · 2024-09-04T19:01:08Z

@freeboub
I think we need to include a comment about the subtitlesFollowVideo property when releasing a new version with these changes. The comment should read: This property was effective before version 6.4.6.

freeboub · 2024-09-04T20:42:38Z

@seyedmostafahasani following text is presented twice in the doc and is not true anymore, can you please have a look to this point ?

On iOS, this displays the video in a fullscreen view controller with controls.
On Android, this puts the navigation controls in fullscreen mode. It is not a complete fullscreen implementation, so you will still need to apply a style that makes the width and height match your screen dimensions to get a fullscreen video.

freeboub · 2024-09-05T08:12:45Z

sorry @seyedmostafahasani but we cannot merge this PR as is.
look the zapping with the sample when we are in stretch mode:
With your version:
newVersion.webm
With current master:
oldVersion.webm

On new version there is a remaining black square (I think it is the shutterView) during content change

android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java

freeboub · 2024-09-05T08:26:52Z

Another video with a 'normal' usage, We also see strange resizing during navigation, please see the video:
Normal.webm

If we want to progress with this PR, I think we should split it in sub PRs, maybe move in another PR the new features would be a good first step. (showSubtitleButton and showSettingButton)

seyedmostafahasani · 2024-09-05T09:49:06Z

sorry @seyedmostafahasani but we cannot merge this PR as is. look the zapping with the sample when we are in stretch mode: With your version: newVersion.webm With current master: oldVersion.webm

On new version there is a remaining black square (I think it is the shutterView) during content change

I am checking it.

# Conflicts: # android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.kt

seyedmostafahasani · 2024-09-13T16:10:54Z

@freeboub
Did you see my changes?

freeboub · 2024-09-13T16:19:26Z

@seyedmostafahasani No sorry, no time to test for now. I'll do it soon !

freeboub · 2024-10-01T22:16:47Z

android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt

    var hideSeekBar: Boolean = false
    var seekIncrementMS: Int = 10000
    var hideDuration: Boolean = false
+    var showSubtitleButton: Boolean = true


@seyedmostafahasani Can you please start by extracting showSubtitleButton & showSettingButton in a separated PR please ?
I am not sure this PR will me merged unfortunnatly, I am afraid of posssible regressions :/

Thanks for reviewing again.
Yeah, sure.
I will do it.

KrzysztofMoch · 2024-10-28T12:53:32Z

@seyedmostafahasani I would like to merge this, if you don't have time to resolve conflicts please let me know I will clone PR and do It by myself

seyedmostafahasani · 2024-11-04T08:52:39Z

@KrzysztofMoch
I will do it tonight.

guihendias · 2024-11-04T13:11:40Z

Just a comment: This PR will not close #3232 since the iOS implementation has not been added. If someone could add the same feat on iOS, it would be ACE! 🙏

Great work all around!

fredrifoUni · 2024-12-04T19:05:02Z

@seyedmostafahasani @freeboub

Hi, I just wanted to check in about the status on this PR. These are some great changes, and I would love to see them merged in.

seyedmostafahasani · 2024-12-05T16:13:53Z

@fredrifoUni
I will work on it over the weekend. Sorry, I’ve been very busy these days, but I’ll resolve all conflicts then. I think we can merge it afterward.

fredrifoUni · 2024-12-05T16:23:56Z

@fredrifoUni I will work on it over the weekend. Sorry, I’ve been very busy these days, but I’ll resolve all conflicts then. I think we can merge it afterward.

That's great to hear. Thank you!

seyedmostafahasani added 2 commits June 15, 2024 03:05

chore(android): update UI controller according to media3

4f568d3

fix: import path

8c84728

seyedmostafahasani marked this pull request as draft June 15, 2024 06:20

freeboub suggested changes Jun 15, 2024

View reviewed changes

seyedmostafahasani added 2 commits June 17, 2024 01:09

chore: update fullScreen prop functionality

72f5732

chore(doc): update document about fullScreen prop

bba24b1

seyedmostafahasani added 6 commits June 17, 2024 01:31

fix: allow chunckless preparation conflict

7c215c9

fix: drm prop conflict

5ab02f2

fix: build sample app

9ab93e3

fix: declare useCache variable

30d29e8

fix: registerPlayer type

edbd682

fix: import object path

be13ab2

seyedmostafahasani marked this pull request as ready for review June 16, 2024 23:00

seyedmostafahasani requested a review from freeboub June 16, 2024 23:00

freeboub suggested changes Jun 18, 2024

View reviewed changes

android/src/main/java/com/brentvatne/common/api/Source.kt Show resolved Hide resolved

docs/pages/component/props.mdx Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.java Outdated Show resolved Hide resolved

seyedmostafahasani added 2 commits June 18, 2024 13:28

fix: revert function and prop

dd33573

fix: import path

9fbca52

seyedmostafahasani requested a review from freeboub June 18, 2024 10:07

chore: show subtitle button

e9493a1

chore: remove additional code

9e20777

fix: adjust controller status based on the controls prop

b44b3ba

seyedmostafahasani added 2 commits August 25, 2024 14:11

Merge branch 'master' into chore/UI-controller

81f929f

# Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java

seyedmostafahasani added 2 commits September 4, 2024 21:33

fix: linter error

5acb307

seyedmostafahasani mentioned this pull request Sep 4, 2024

[BUG]: dismiss video player hides statusbar and navigation bar #4107

Closed

freeboub reviewed Sep 5, 2024

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java Show resolved Hide resolved

seyedmostafahasani added 2 commits September 6, 2024 22:47

fix: shutter view status

1340da3

Merge branch 'master' into chore/UI-controller

8293f1d

# Conflicts: # android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.kt

seyedmostafahasani requested a review from freeboub September 6, 2024 19:19

freeboub reviewed Oct 1, 2024

View reviewed changes

fredrifoUni mentioned this pull request Nov 19, 2024

Render the metadata title in Android player controls #4265

Open

KrzysztofMoch added this to React Native Video - Public Roadmap Mar 5, 2025

github-project-automation bot moved this to To Triage in React Native Video - Public Roadmap Mar 5, 2025

Conversation

seyedmostafahasani commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Changes

Test plan

Uh oh!

freeboub left a comment

Choose a reason for hiding this comment

Uh oh!

bulkinav commented Jun 15, 2024

Uh oh!

seyedmostafahasani commented Jun 16, 2024

Uh oh!

seyedmostafahasani commented Jun 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seyedmostafahasani commented Jun 18, 2024

Uh oh!

seyedmostafahasani commented Jun 20, 2024

Uh oh!

ashnfb commented Jun 20, 2024

Uh oh!

seyedmostafahasani commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seyedmostafahasani commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freeboub commented Jun 21, 2024

Uh oh!

JerakRus commented Aug 16, 2024

Uh oh!

seyedmostafahasani commented Aug 21, 2024

Uh oh!

freeboub commented Sep 4, 2024

Uh oh!

seyedmostafahasani commented Sep 4, 2024

Uh oh!

seyedmostafahasani commented Sep 4, 2024

Uh oh!

freeboub commented Sep 4, 2024

Uh oh!

freeboub commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

freeboub commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seyedmostafahasani commented Sep 5, 2024

Uh oh!

seyedmostafahasani commented Sep 13, 2024

Uh oh!

freeboub commented Sep 13, 2024

Uh oh!

freeboub Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

seyedmostafahasani Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

KrzysztofMoch commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seyedmostafahasani commented Nov 4, 2024

Uh oh!

guihendias commented Nov 4, 2024

Uh oh!

fredrifoUni commented Dec 4, 2024

Uh oh!

seyedmostafahasani commented Dec 5, 2024

Uh oh!

fredrifoUni commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

seyedmostafahasani commented Jun 14, 2024 •

edited

Loading

seyedmostafahasani commented Jun 21, 2024 •

edited

Loading

seyedmostafahasani commented Jun 21, 2024 •

edited

Loading

freeboub commented Sep 5, 2024 •

edited

Loading

freeboub commented Sep 5, 2024 •

edited

Loading

KrzysztofMoch commented Oct 28, 2024 •

edited

Loading