-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: add method for getting current playback status #4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: support/6.x.x
Are you sure you want to change the base?
Changes from all commits
86b4279
d243262
d03de51
2a0cdc4
dac32dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,15 @@ export type ReactVideoSourceProperties = { | |
| textTracks?: TextTracks; | ||
| }; | ||
|
|
||
| export type TPlaybackStatus = { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PlaybackStatus would be enough ?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's better to add the prefix
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As Robert Martin wrote in his "Clean Code" - T, I, Enum, List (and so on) prefixes/suffixes before types, interfaces, enums (and so on) are meaningless. We are not necessarily need to follow what he writes in his books, but it's better to follow guidelines that are accepted in the project you are working on (for example, as I can see in this project suffixes/prefixes are not used) |
||
| paused: 'paused'; | ||
| playing: 'playing'; | ||
| buffering: 'buffering'; | ||
| ended: 'ended'; | ||
| idle: 'idle'; | ||
| unknown: 'unknown'; | ||
| }; | ||
|
|
||
| export type ReactVideoSource = Readonly< | ||
| Omit<ReactVideoSourceProperties, 'uri'> & { | ||
| uri?: string | NodeRequire; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.