Open
Conversation
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BUG]: Video rect not updating #4488 on Android.
Motivation
On Android, the Picture-in-Picture (PIP) feature did not correctly resize the video when exiting PIP mode and returning to the app. The video retained the PIP dimensions instead of adapting to the normal screen size.
Changes
Modified ReactExoplayerView.java.
In setIsInPictureInPicture, added a post(requestLayout()) to force the layout recalculation after exiting PIP.
Result: video now correctly resizes to fit the screen after leaving PIP.
Test plan