Skip to content

BAC-463 - Add support for Cloudflare microservices chart types#67

Open
churma wants to merge 1 commit intomasterfrom
BAC-463-microservices-v8-cloudflare-integration
Open

BAC-463 - Add support for Cloudflare microservices chart types#67
churma wants to merge 1 commit intomasterfrom
BAC-463-microservices-v8-cloudflare-integration

Conversation

@churma
Copy link
Contributor

@churma churma commented Jan 30, 2026

Summary

  • Add microservices-cf-v1-secrets-ext and microservices-cf to the list of valid old-school Helm chart names
  • Update validation error message to include the new allowed values

Test plan

  • Verify orb builds successfully
  • Test migration from microservices-cf chart to ArgoCD
  • Test migration from microservices-cf-v1-secrets-ext chart to ArgoCD

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated deployment validation to accept additional chart configurations for improved compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

Add microservices-cf-v1-secrets-ext and microservices-cf to the list of
valid old-school Helm chart names for ArgoCD migration validation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Walkthrough

A validation step in an Argo deployment workflow was updated to accept two additional previous chart names (microservices-cf-v1-secrets-ext and microservices-cf) in its case statement, with corresponding updates to the error message.

Changes

Cohort / File(s) Summary
Validation step enhancement
src/jobs/argo-deploy.yml
Expanded case statement to accept two additional previous chart names with updated error message listing all accepted values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is missing the required 'Why?' and 'Additional Links' sections from the template, though it does provide a summary and test plan. Add the 'Why?' section explaining the business reason for supporting these chart types, and include relevant links (e.g., BAC-463 Jira ticket).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding support for two new Cloudflare microservices chart types to the validation logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BAC-463-microservices-v8-cloudflare-integration

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants