feat: Make notify device cooldown configurable and cleanup constants. #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
JFreegman
reviewed
Jan 20, 2026
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
This will need to be documented in the toxic.conf man page
@JFreegman reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 0 of 1 approvals obtained.
iphydf
force-pushed
the
config-cooldown
branch
from
583d751 to
16b9048
Compare
iphydf
commented
Jan 20, 2026
Member
Author
iphydf
left a comment
iphydf
left a comment
There was a problem hiding this comment.
Done.
@iphydf made 1 comment.
Reviewable status: 0 of 1 approvals obtained.
iphydf
force-pushed
the
config-cooldown
branch
from
16b9048 to
aa9bcb7
Compare
iphydf
force-pushed
the
config-cooldown
branch
4 times, most recently
from
de566be to
3a4c190
Compare
- Add `device_cooldown` option to `Client_Config`, defaulting to 5 seconds. - Load `device_cooldown` from configuration file. - Replace hardcoded `sleep_thread` durations in `src/notify.c` with named constants.
iphydf
force-pushed
the
config-cooldown
branch
from
3a4c190 to
f6d679a
Compare
JFreegman
approved these changes
Jan 22, 2026
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
@JFreegman reviewed 6 files and all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_cooldownoption toClient_Config, defaulting to 5 seconds.device_cooldownfrom configuration file.sleep_threaddurations insrc/notify.cwith named constants.This change is