C#7.3 Compatibility, .Net Standart 2.0#106
Open
blauertee wants to merge 10 commits intoTouseefelahi:masterfrom
Open
C#7.3 Compatibility, .Net Standart 2.0#106blauertee wants to merge 10 commits intoTouseefelahi:masterfrom
blauertee wants to merge 10 commits intoTouseefelahi:masterfrom
Conversation
added 7 commits
July 5, 2024 16:07
Owner
|
Thank you for the PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is definetly not ready to be merged.
Target Frameworks have to be Edited and I'm not sure whether you really want to give up on the syntactic shugar of C#9.0.
Also all methods taking
byte[]as an argument don't acceptSpan<byte>in C#7.3 so I just lazily insertedToArray()everywhere, not sure what this does under the hood but it could lead to serous performance issues.But I thought this may be useful for someone anyway. :)