Conversation
JonnyPower
commented
Jun 11, 2025
- same directory as input
- same filename with results suffix
- same directory as input - same filename with results suffix
There was a problem hiding this comment.
Bug: Filename Collision Resolution Fails
The resolveFileNameCollision method incorrectly determines the filename and extension for collision resolution. It uses originalFile.getAbsolutePath() to find the last dot, instead of originalFile.getName(). This causes incorrect parsing when directory names contain dots (e.g., /home/user.name/file.txt, /tmp/version1.2/myfile.txt) or when dealing with hidden files (e.g., /path/to/.bashrc). As a result, collision-resolved filenames are malformed (e.g., /home/user (1).name/file, /path/to/ (1).bashrc).
src/main/java/com/tractionrec/recrec/ui/RecRecResultsPreview.java#L669-L697
recrec/src/main/java/com/tractionrec/recrec/ui/RecRecResultsPreview.java
Lines 669 to 697 in 0bac776
Bug: Export Filename Extension Handling Flaw
The getDefaultExportFileName() method incorrectly derives default export filenames from input files. It preserves the original file's extension (e.g., data.txt), leading to confusing double extensions like data - results.txt.csv after the export logic appends .csv. Additionally, the logic for identifying extensions (if (dotIndex > 0)) is flawed, causing unusual filenames for files ending with a dot (e.g., file. becomes file - results.), as it treats the trailing dot as an extension.
src/main/java/com/tractionrec/recrec/ui/RecRecResultsPreview.java#L606-L617
recrec/src/main/java/com/tractionrec/recrec/ui/RecRecResultsPreview.java
Lines 606 to 617 in 0bac776
Was this report helpful? Give feedback by reacting with 👍 or 👎