fix(react): replace React.lazy with synchronous createComponent in Re…#1184
Open
Anexus5919 wants to merge 1 commit intoTrendyol:nextfrom
Open
fix(react): replace React.lazy with synchronous createComponent in Re…#1184Anexus5919 wants to merge 1 commit intoTrendyol:nextfrom
Anexus5919 wants to merge 1 commit intoTrendyol:nextfrom
Conversation
…act wrappers React wrappers were using React.lazy + customElements.whenDefined, which always triggers Suspense fallback on first render causing a visible UI flash. Replace with direct ES module imports of component classes and synchronous createComponent calls. The @CustomElement decorator registers elements as a side-effect of the import, guaranteeing elementClass is defined before createComponent accesses it. Fixes Trendyol#1171
Author
|
@Enes5519 @ergenekonyigit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React wrappers in
baklava-react.tswere usingReact.lazy()+customElements.whenDefined()to create component wrappers.React.lazyalways suspends on the first render, triggering the nearest<Suspense>fallback and causing a visible UI flash/blink even when the custom element is already registered.This PR replaces the lazy pattern with direct ES module imports and synchronous
createComponent()calls. The@customElementdecorator in each component file registers the element as a side-effect of the import, guaranteeingelementClassis defined beforecreateComponentaccesses it.Before (causes suspension):
After (synchronous, no flash):
Benefits
createComponent()runsimport '@trendyol/baklava'side-effect import when using React wrappersChanged files
cemPlugins/generateReactExports.js- updated generator to emit direct imports and synchronouscreateComponent()callscemPlugins/utils/resolveFilePath.js- extractedresolveImportPath()utility for raw import pathsChecklist
Fixes #1171