feature: support 'http://IP/wake?name=MACHINENAME' as url parameter#22
Open
clunkclunk wants to merge 1 commit into
Open
feature: support 'http://IP/wake?name=MACHINENAME' as url parameter#22clunkclunk wants to merge 1 commit into
clunkclunk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for URL parameters to specify what machine to wake, such as
http://192.168.0.123/wake?name=Laptopby adding a 'get' endpoint. Just a one line addition. I wanted to use a simple browser bookmark to wake up one of my machines, and this was a surprisingly easy fix. #8 was close, but I couldn't easily get a post to behave itself in a standard browser bookmark and work with my auth redirect (I use tinyauth).In terms of security implications, I don't think it's huge as while a bookmark or other link could be directed to that URL, the damage would be mitigated to waking the machine only, and just like the main page of wol, it should always be behind a firewall or other authorization system.
I tested in my browser, and with
curl "http://localhost:7777/wake?name=desktop"and it operated as expected. Existing POST behavior withcurl -X POST http://localhost:7777/wake -d "name=desktop"continued to operate as expected.