Fix navigation menu visibility issue on desktop screens#1011
Open
dohyeondk wants to merge 1 commit intoTryGhost:mainfrom
Open
Fix navigation menu visibility issue on desktop screens#1011dohyeondk wants to merge 1 commit intoTryGhost:mainfrom
dohyeondk wants to merge 1 commit intoTryGhost:mainfrom
Conversation
- Removed media query that set opacity: 0 on nav items before dropdown loaded - Prevents flash of invisible content on larger screens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the intermittent navigation menu visibility issue reported in #1009.
Problem
Navigation menu items were sometimes invisible on desktop screens (width > 992px) due to a CSS rule that set
opacity: 0on nav items before the dropdown JavaScript loaded. If the JavaScript failed to load or was delayed, the menu items would remain invisible.Solution
Removed the problematic media query that was hiding navigation items:
This ensures navigation menu items are always visible regardless of JavaScript loading state.
Changes
.is-dropdown-loadedclassTesting
Fixes #1009
Note
Removes the CSS rule that hid desktop nav items before dropdown init, ensuring the menu is always visible, and updates the built CSS and source map.
assets/css/screen.cssthat setopacity: 0for.gh-head-menu .nav > lion desktop whenbody:not(.is-dropdown-loaded).assets/built/screen.cssandassets/built/screen.css.mapto reflect the change.Written by Cursor Bugbot for commit 0bb9bdd. This will update automatically on new commits. Configure here.