Apply fail-closed pnpm security baseline - #258
Draft
9larsons wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
minimumReleaseAge: 4320strictDepBuilds: trueblockExoticSubdeps: truesqlite3build permission to the two exact versions inpnpm-lock.yaml:5.1.7and6.0.1dtrace-providerdenial and explicitly deny the already-skipped transitivebetter-sqlite3buildWhy
The previous package-wide
sqlite3: trueentry allowed any future SQLite version selected by the lockfile to run lifecycle scripts. The workspace also relied on pnpm defaults for package age, unknown build handling, and exotic transitive sources.This makes the security behavior explicit and fail-closed without granting any new build capability. A clean strict install identified
better-sqlite3@12.11.1as an existing implicitly ignored build; recording it asfalsepreserves that behavior while allowing strict frozen installs to complete.Impact
Both locked SQLite versions retain the native bindings required by the current dependency graph. Any new SQLite version, undeclared lifecycle script, or exotic transitive source now requires an explicit reviewed configuration change.
Validation
pnpm@10.34.5 install --frozen-lockfilepnpm install --frozen-lockfile --prefer-offlinepnpm test:ci— 78 tests passed; coverage gates, oxlint, and oxfmt passedsqlite3@5.1.7andsqlite3@6.0.1native bindings and successfully queried in-memory databasesbetter-sqlite3native binding was builtpnpm pack --dry-run— expected library files onlyThere is no separate build script for this CommonJS library; CI-parity tests and the package dry run cover the distributable path.
Refs PLA-320