Media 1202 - #50
Merged
Merged
Conversation
This was referenced Mar 23, 2026
Merged
There was a problem hiding this comment.
Pull request overview
Reworks the News “hero image” field block template to align with the theme’s Emulsify/BEM-based block markup patterns, likely as part of the broader “News Images - Rework” effort.
Changes:
- Wraps output in a
content|render|trimemptiness check to avoid rendering an empty block container. - Switches the wrapper markup to use
bem()instead ofattributes.addClass('pull-left'). - Updates the label heading to add the
h2class viatitle_attributes.
Comments suppressed due to low confidence (1)
templates/block/block--field-block--node--news--field-media-hero-image.html.twig:30
bem()is being called with a first argument of'block pull-left'. Elsewhere in the theme, additional classes are passed either as an array (e.g.,bem(['no-list-style'])) or via the 4thextraargument. Passing a space-delimited string here can cause BEM class generation to treatpull-leftas part of the base class and produce incorrect modifier classes (e.g.,pull-left--<modifier>). Consider keeping the base class as'block'and passing'pull-left'as an extra class (or pass['block', 'pull-left']as the base).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe context / purpose for this PR
News Images - Rework
Issue link
#1202
Any other related PRs?
Link to MultiDev instance
http://md-1202-ucbsub-oit.pantheonsite.io
Checklist for PR author