Skip to content

fix(ui5-timeline, ui5-view-settings-dialog): correct parameters definition #12915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hinzzx merged 4 commits into from
Jan 19, 2026
Merged

fix(ui5-timeline, ui5-view-settings-dialog): correct parameters definition #12915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
647f851
fix(ui5-timeline, ui5-view-settings-dialog): correct parameters defin…
hinzzx Jan 15, 2026
74904e5
move params for sap fiori 3 dark,hcb and hcw
hinzzx Jan 15, 2026
a86cc0b
fix minor issues
hinzzx Jan 16, 2026
c9b8964
Merge branch 'main' into tl-vsd-params-definition
hinzzx Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/fiori/src/themes/base/TimelineGroupItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
:root {
--_ui5_timeline_tlgi_line_horizontal_height: 14.8125rem;
--_ui5_timeline_tlgi_root_horizontal_height: 19.9375rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_timeline_tlgi_compact_icon_before_height: calc(100% + 1.5rem);
--_ui5_timeline_tlgi_horizontal_line_placeholder_before_width: var(--_ui5_timeline_tlgi_compact_icon_before_height);
--_ui5_timeline_tlgi_horizontal_compact_root_margin_left: 0.5rem;
--_ui5_timeline_tlgi_compact_root_gap: 0.5rem;
--_ui5_timeline_tlgi_root_horizontal_height: 19.375rem;
}
50 changes: 50 additions & 0 deletions packages/fiori/src/themes/base/TimelineItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,54 @@
--_ui5_TimelineItem_bubble_content_padding: var(--_ui5_tl_bubble_padding);
--_ui5_TimelineItem_bubble_content_subtitle_padding_top: 0.375rem;
--_ui5_TimelineItem_bubble_content_description_padding_top: 0.75rem;

/* Timeline (container) */
--_ui5_tl_bubble_padding: 1rem;
--_ui5_tl_padding: 1rem 1rem 1rem .5rem;
--_ui5_tl_li_margin_bottom: 1.625rem;

/* TimelineItem */
--_ui5_timeline_tli_indicator_before_bottom: -1.5rem;
--_ui5_timeline_tli_indicator_before_right: -1.625rem;
--_ui5_timeline_tli_indicator_before_without_icon_bottom: -1.875rem;
--_ui5_timeline_tli_indicator_before_without_icon_right: -1.9375rem;

/* TimelineItem COZY */
--_ui5_timeline_tli_indicator_after_top: calc(-100% - 1rem);
--_ui5_timeline_tli_indicator_after_height: calc(100% + 1rem);
--_ui5_timeline_tli_indicator_before_height: 100%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% + 0.25rem);
--_ui5_timeline_tli_horizontal_indicator_after_left: 1.9375rem;
--_ui5_timeline_tli_horizontal_without_icon_indicator_before_width: calc(100% + 0.5rem);
--_ui5_timeline_tli_horizontal_indicator_before_width: calc(100% + 0.5rem);
--_ui5_timeline_tli_icon_horizontal_indicator_after_width: calc(100% + 0.25rem);
--_ui5_timeline_tli_without_icon_horizontal_indicator_before_width: calc(100% + 0.375rem);
--_ui5_timeline_tli_horizontal_indicator_short_after_width: 100%;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
/* Timeline (container) */
--_ui5_tl_bubble_padding: .5rem;
--_ui5_tl_padding: .5rem;
--_ui5_tl_li_margin_bottom: .5rem;

/* TimelineItem */
--_ui5_timeline_tli_indicator_before_bottom: -0.75rem;
--_ui5_timeline_tli_indicator_before_right: -0.5rem;
--_ui5_timeline_tli_indicator_before_without_icon_bottom: -1rem;
--_ui5_timeline_tli_indicator_before_without_icon_right: -0.8125rem;

/* TimelineItem COMPACT */
--_ui5_timeline_tli_indicator_before_height: calc(100% - 1.25rem);
--_ui5_timeline_tli_horizontal_without_icon_indicator_before_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_horizontal_indicator_after_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_horizontal_indicator_before_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_icon_horizontal_indicator_after_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_indicator_after_top: calc(-100% + 0.9375rem);
--_ui5_timeline_tli_indicator_after_height: calc(100% - 0.75rem);
--_ui5_timeline_tli_horizontal_indicator_after_left: 1.8625rem;
--_ui5_timeline_tli_horizontal_indicator_short_after_width: calc(100% - 1rem);
--_ui5_timeline_tli_without_icon_horizontal_indicator_before_width: calc(100% - 0.625rem);
}
8 changes: 8 additions & 0 deletions packages/fiori/src/themes/base/ViewSettingsDialog-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,12 @@
--_ui5_vsd_content_li_padding: 0.375rem;
--_ui5_vsd_content_height: 23.4375rem;
--_ui5_vsd_expand_content_height: 26.1875rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_vsd_header_container: 2.5rem;
--_ui5_vsd_sub_header_container_height: 2rem;
--_ui5_vsd_expand_content_height: 25.4375rem;
}
6 changes: 6 additions & 0 deletions packages/fiori/src/themes/sap_fiori_3/TimelineGroupItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,10 @@
:root {
--_ui5_timeline_tlgi_line_horizontal_height: 16.375rem;
--_ui5_timeline_tlgi_root_horizontal_height: 21.53125rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_timeline_tlgi_root_horizontal_height: 20.90625rem;
}
11 changes: 11 additions & 0 deletions packages/fiori/src/themes/sap_fiori_3/TimelineItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
@import "../base/TimelineItem-parameters.css";

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
/* Timeline Item COMPACT - sap_fiori_3 specific values */
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
--_ui5_timeline_tli_icon_horizontal_indicator_after_width: calc(100% - 0.75rem);
}
3 changes: 2 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@import "../base/ProductSwitchItem-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/SideNavigation-parameters.css";
@import "../base/TimelineItem-parameters.css";
@import "./TimelineItem-parameters.css";
@import "../base/UploadCollection-parameters.css";
@import "../base/ViewSettingsDialog-parameters.css";
@import "../base/Wizard-parameters.css";
Expand All @@ -19,4 +19,5 @@
@import "../base/DynamicPageHeader-parameters.css";
@import "./DynamicPageHeaderActions-parameters.css";
@import "./TimelineGroupItem-parameters.css";
@import "../base/rtl-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
9 changes: 9 additions & 0 deletions packages/fiori/src/themes/sap_fiori_3_dark/TimelineItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
@import "../base/TimelineItem-parameters.css";

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
}
3 changes: 2 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_dark/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@import "../base/ProductSwitchItem-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/SideNavigation-parameters.css";
@import "../base/TimelineItem-parameters.css";
@import "./TimelineItem-parameters.css";
@import "../base/UploadCollection-parameters.css";
@import "../base/ViewSettingsDialog-parameters.css";
@import "../base/Wizard-parameters.css";
Expand All @@ -19,4 +19,5 @@
@import "../base/DynamicPageHeader-parameters.css";
@import "../sap_fiori_3/DynamicPageHeaderActions-parameters.css";
@import "../sap_fiori_3/TimelineGroupItem-parameters.css";
@import "../base/rtl-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
8 changes: 8 additions & 0 deletions packages/fiori/src/themes/sap_fiori_3_hcb/TimelineItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@
:root {
--_ui5_TimelineItem_bubble_rtl_left_offset: -0.1875rem;
--_ui5_TimelineItem_bubble_rtl_right_offset: -0.6875rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
}
3 changes: 2 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcb/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
@import "../base/DynamicPageHeader-parameters.css";
@import "../sap_fiori_3/DynamicPageHeaderActions-parameters.css";
@import "../sap_fiori_3/TimelineGroupItem-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
@import "../base/rtl-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
8 changes: 8 additions & 0 deletions packages/fiori/src/themes/sap_fiori_3_hcw/TimelineItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@
:root {
--_ui5_TimelineItem_bubble_rtl_left_offset: -0.1875rem;
--_ui5_TimelineItem_bubble_rtl_right_offset: -0.6875rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
}
3 changes: 2 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcw/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
@import "../base/DynamicPageHeader-parameters.css";
@import "../sap_fiori_3/DynamicPageHeaderActions-parameters.css";
@import "../sap_fiori_3/TimelineGroupItem-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
@import "../base/rtl-parameters.css";
@import "../base/UserSettingsAppearanceViewItem-parameters.css";
56 changes: 0 additions & 56 deletions packages/main/src/themes/base/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@
--_ui5_token_height: 1.625rem;
--_ui5_token_icon_size: .75rem;
--_ui5_token_icon_padding: 0.25rem 0.5rem;
--_ui5_tl_bubble_padding: 1rem;
--_ui5_tl_padding: 1rem 1rem 1rem .5rem;
--_ui5_tl_li_margin_bottom: 1.625rem;

/*switch*/
--_ui5_tc_item_text: 3rem;
Expand Down Expand Up @@ -138,24 +135,6 @@
--_ui5-tree-toggle-box-height: 2.25rem;
--_ui5-tree-toggle-icon-size: 1.0625rem;

/* Timeline */
--_ui5_timeline_tli_indicator_before_bottom: -1.5rem;
--_ui5_timeline_tli_indicator_before_right: -1.625rem;
--_ui5_timeline_tli_indicator_before_without_icon_bottom: -1.875rem;
--_ui5_timeline_tli_indicator_before_without_icon_right: -1.9375rem;

/* TimelineItem COZY */
--_ui5_timeline_tli_indicator_after_top: calc(-100% - 1rem);
--_ui5_timeline_tli_indicator_after_height: calc(100% + 1rem);
--_ui5_timeline_tli_indicator_before_height: 100%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% + 0.25rem);
--_ui5_timeline_tli_horizontal_indicator_after_left: 1.9375rem;
--_ui5_timeline_tli_horizontal_without_icon_indicator_before_width: calc(100% + 0.5rem);
--_ui5_timeline_tli_horizontal_indicator_before_width: calc(100% + 0.5rem);
--_ui5_timeline_tli_icon_horizontal_indicator_after_width: calc(100% + 0.25rem);
--_ui5_timeline_tli_without_icon_horizontal_indicator_before_width: calc(100% + 0.375rem);
--_ui5_timeline_tli_horizontal_indicator_short_after_width: 100%;

/* SplitButton */
--_ui5_split_button_middle_separator_top: -0.0625rem;
--_ui5_split_button_middle_separator_height: 2.25rem;
Expand Down Expand Up @@ -325,10 +304,6 @@
--_ui5_token_icon_padding: 0.375rem 0.375rem;
--_ui5_token_outline_offset: -0.125rem;

--_ui5_tl_bubble_padding: .5rem;
--_ui5_tl_padding: .5rem;
--_ui5_tl_li_margin_bottom: .5rem;

--_ui5_tc_item_text: 2rem;
--_ui5_tc_item_text_line_height: 1.325rem;
--_ui5_tc_item_icon_size: 1rem;
Expand Down Expand Up @@ -370,37 +345,6 @@
--_ui5-tree-toggle-box-height: 1.5rem;
--_ui5-tree-toggle-icon-size: 0.8125rem;

/* Timeline */
--_ui5_timeline_tli_indicator_before_bottom: -0.75rem;
--_ui5_timeline_tli_indicator_before_right: -0.5rem;
--_ui5_timeline_tli_indicator_before_without_icon_bottom: -1rem;
--_ui5_timeline_tli_indicator_before_without_icon_right: -0.8125rem;

/* TimelineItem */
--_ui5_timeline_tli_indicator_before_height: calc(100% - 1.25rem);
--_ui5_timeline_tli_horizontal_without_icon_indicator_before_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_horizontal_indicator_after_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_horizontal_indicator_before_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_icon_horizontal_indicator_after_width: var(--_ui5_timeline_tli_indicator_after_height);
--_ui5_timeline_tli_indicator_after_top: calc(-100% + 0.9375rem);
--_ui5_timeline_tli_indicator_after_height: calc(100% - 0.75rem);
--_ui5_timeline_tli_horizontal_indicator_after_left: 1.8625rem;
--_ui5_timeline_tli_horizontal_indicator_short_after_width: calc(100% - 1rem);
--_ui5_timeline_tli_without_icon_horizontal_indicator_before_width: calc(100% - 0.625rem);

/* TimelineGroupItem */
--_ui5_timeline_tlgi_compact_icon_before_height: calc(100% + 1.5rem);
--_ui5_timeline_tlgi_horizontal_line_placeholder_before_width: var(--_ui5_timeline_tlgi_compact_icon_before_height);
--_ui5_timeline_tlgi_horizontal_compact_root_margin_left: 0.5rem;
--_ui5_timeline_tlgi_compact_root_gap: 0.5rem;
--_ui5_timeline_tlgi_root_horizontal_height: 19.375rem;


/* ViewSettingsDialog */
--_ui5_vsd_header_container: 2.5rem;
--_ui5_vsd_sub_header_container_height: 2rem;
--_ui5_vsd_expand_content_height: 25.4375rem;

/* Toolbar */
--_ui5-toolbar-separator-height: 1.5rem;
--_ui5-toolbar-height: 2rem;
Expand Down
8 changes: 0 additions & 8 deletions packages/main/src/themes/sap_fiori_3/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@
/* ColorPicker */
--_ui5_color_picker_slider_handle_container_margin_top: none;

/* Timeline Item */
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);

/* Timeline Group Item */
--_ui5_timeline_tlgi_root_horizontal_height: 20.90625rem;

/* Slider, Range Slider */
--_ui5_slider_handle_width: 1.25rem;
--_ui5_slider_handle_height: 1.25rem;
Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_dark/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
/* ColorPicker */
--_ui5_color_picker_slider_handle_container_margin_top: none;

/* Timeline Item */
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);

/* Slider, Range Slider */
--_ui5_slider_handle_width: 1.25rem;
--_ui5_slider_handle_height: 1.25rem;
Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_hcb/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,4 @@

/* ColorPicker */
--_ui5_color_picker_slider_handle_container_margin_top: none;

/* Timeline Item */
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
}
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_hcw/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,4 @@

/* ColorPicker */
--_ui5_color_picker_slider_handle_container_margin_top: none;

/* Timeline Item */
--_ui5_timeline_tli_indicator_after_height: 50%;
--_ui5_timeline_tli_indicator_after_top: -50%;
--_ui5_timeline_tli_horizontal_indicator_after_width: calc(100% - 1rem);
}
Loading