add missing semicolon to log_error call in scorer persist path - #26
Merged
Conversation
dcorral
force-pushed
the
fix/nightly-trailing-semicolon
branch
from
July 16, 2026 08:26
213e198 to
9576c51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest Rust nightly promoted the semicolon_in_expressions_from_macros lint from warn to deny-by-default, which turns a log_error! invocation used in expression position (its expansion ends with a trailing semicolon) into a hard build error in lightning-background-processor. This broke every nightly CI build of rgb-lightning-node that compiles this submodule. The fix is a single semicolon so the macro call is a statement rather than the block's tail expression, with no behavior change. See the lint's entry in the nightly rustc docs: https://doc.rust-lang.org/nightly/rustc/lints/listing/deny-by-default.html#semicolon-in-expressions-from-macros (tracking issue rust-lang/rust#79813).