Skip to content

Increase metric buckets for sale records read#1419

Merged
karashiiro merged 1 commit intoUniversalis-FFXIV:v2from
karashiiro:chore/metric-tweaks
Oct 18, 2025
Merged

Increase metric buckets for sale records read#1419
karashiiro merged 1 commit intoUniversalis-FFXIV:v2from
karashiiro:chore/metric-tweaks

Conversation

@karashiiro
Copy link
Copy Markdown
Member

@karashiiro karashiiro commented Oct 18, 2025

Summary by CodeRabbit

  • Chores
    • Adjusted internal metrics collection configuration for improved granularity.

@karashiiro karashiiro merged commit 0ec99cb into Universalis-FFXIV:v2 Oct 18, 2025
2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The Prometheus histogram configuration for RowsReadCount metric in SaleStore.cs is updated by doubling the bucket count from 16 to 32, enhancing histogram granularity for metrics collection without modifying functional logic or control flow.

Changes

Cohort / File(s) Change Summary
Prometheus Histogram Configuration
src/Universalis.DbAccess/MarketBoard/SaleStore.cs
Increased RowsReadCount histogram bucket count from 16 to 32 for improved metrics granularity

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Sixteen buckets held the count so tight,
Now thirty-two shall shine more bright,
A rabbit's metrics, refined and true,
Prometheus grins at the finer view,
🥕📊 Granularity blooms anew!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 36a54e5 and 68dcfb6.

📒 Files selected for processing (1)
  • src/Universalis.DbAccess/MarketBoard/SaleStore.cs (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@karashiiro karashiiro deleted the chore/metric-tweaks branch October 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant