Apply hardcoded DC mapping patch to other game data providers

[karashiiro]

Summary by CodeRabbit

• Bug Fixes
  • Corrected data center world mappings to resolve association issues.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes refactor data center world ID loading in two game data providers. Instead of relying on an upstream DataCenter.RowId field (noted as broken), the code now uses a precomputed world-name-to-ID mapping combined with GlobalServers.WorldToDataCenter to correctly associate worlds with data centers.

Changes

Cohort / File(s)	Summary
Data center world mapping fix src/Universalis.GameData/BoilmasterGameDataProvider.cs, src/Universalis.GameData/CsvGameDataProvider.cs	Replaced upstream DataCenter.RowId-based filtering with a mapping approach using GlobalServers.WorldToDataCenter and precomputed world-name-to-ID lookups to correctly associate worlds with data centers. Added clarifying comment about upstream data issue.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the correctness of the worldNameToId mapping against valid worlds
• Confirm that GlobalServers.WorldToDataCenter lookup is reliable and complete for all expected data centers
• Ensure the filtering logic produces equivalent results to the previous approach (or intentionally corrects it)

Possibly related PRs

• Use Boilmaster as intermediate fallback for game data load failures #1417: Introduced/established the Boilmaster provider functionality that is now being refactored in this PR's changes to the data center loading logic.

Poem

🐰 A rabbit hops through data streams,
Where broken fields were troublesome dreams,
With mapping keys both clean and bright,
The worlds align, their paths align right!
No more RowId confusion—hooray! 🌍✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 663692d and 44197ba.

📒 Files selected for processing (2)

• src/Universalis.GameData/BoilmasterGameDataProvider.cs (1 hunks)
• src/Universalis.GameData/CsvGameDataProvider.cs (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}