Skip to content

Remove completed newProfileDropdown flag and promote enabled path - #12432

Open
ivarconr with Copilot wants to merge 2 commits into
mainfrom
copilot/cleanup-newprofiledropdown-flag
Open

Remove completed newProfileDropdown flag and promote enabled path#12432
ivarconr with Copilot wants to merge 2 commits into
mainfrom
copilot/cleanup-newprofiledropdown-flag

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

newProfileDropdown is marked completed with outcome kept, so the temporary bifurcation is no longer needed. This PR removes the flag wiring and keeps the new profile dropdown behavior as the only code path.

  • Frontend behavior cleanup

    • UserProfileContainer now always renders UserProfile for authenticated users.
    • Header no longer gates theme-toggle visibility on newProfileDropdown; the toggle is rendered unconditionally.
    • Removed obsolete LegacyUserProfile branching from the container.
  • Flag contract cleanup

    • Removed newProfileDropdown from frontend UI flag typings (UiFlags).
    • Removed newProfileDropdown from backend experimental flag key/type and env parsing map.
    • Removed newProfileDropdown from dev server flag defaults.
  • Targeted regression coverage

    • Added focused tests for UserProfileContainer to assert:
      • profile UI renders when a user exists
      • nothing is rendered when no user exists
const UserProfileContainer = () => {
  const { user } = useAuthUser();
  if (!user) return null;
  return <UserProfile profile={user} />;
};

Copilot AI changed the title [WIP] Remove completed feature flag newProfileDropdown Remove completed newProfileDropdown flag and promote enabled path Jun 29, 2026
Copilot AI requested a review from ivarconr June 29, 2026 08:38
@ivarconr
ivarconr marked this pull request as ready for review June 29, 2026 13:00
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants