Use .luau for Wally-generated package links#257
Open
MarsSquirrel wants to merge 2 commits intoUpliftGames:mainfrom
Open
Use .luau for Wally-generated package links#257MarsSquirrel wants to merge 2 commits intoUpliftGames:mainfrom
MarsSquirrel wants to merge 2 commits intoUpliftGames:mainfrom
Conversation
Author
|
Forgot to mention that this change was also proposed in #212 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes update the extension of package link files from
.luato.luau.Problem
While these files are simple proxies for actual package code, I find a mix of
.luaand.luaufiles in my workspace messy and unprofessional. This shift also ensures that Wally’s output meets the official standardization of the Luau Language within Roblox's tooling, creating a more cohesive and semantically accurate file structure.Solution
Updated the file extension of package links to
.luau. Also fixed test snapshots to support the change.Alternate
If fully switching is unfeasible, a flag or TOML value to specify Luau-generated package links would work instead.
This is my first OSS contribution, so feedback is greatly appreciated! I know this is just a small tweak, but it’s a quality-of-life change that I've been wanting to see for a while now. I'd love to know if other developers feel this way. 😄