New chart items#33
Open
iansargent wants to merge 11 commits into
Open
Conversation
FWJK1
reviewed
Jun 9, 2026
FWJK1
reviewed
Jun 9, 2026
| [request.name, request.year_min, request.year_max], | ||
| ).df() | ||
| # If requesting Vermont (state-level), aggregate all counties | ||
| if request.name.lower() == "vermont": |
Collaborator
There was a problem hiding this comment.
Can you update these (and all other SQL queries here) to match the paradigm for the zoning dataset?
That is, move the actual logic here into a subsection of the "serve" folder, with the SQL pumped in from .sql files (and ideally parameterized a bit better, with less repetition).
like a lot of these you could just make table a parameter you pass in. so that its "FROM {table}" or "FROM ?".
FWJK1
requested changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrendChartitems:UnemploymentTrendChart,EarningsTrendChart, andMedianAgeTrend Chartplots.mdfile