Closed
Conversation
Contributor
Author
|
Furthermore, I added the ability for the rod to smelt items in inventory using mana. Mana cost is currently the same per item as it normally is per block, but that is simple to change |
Collaborator
|
I think the application of the block smelting effect should go back to right-click, but it can stay instant. That would also be more consistent with your proposed in-inventory smelting, which uses right-click. However, would it maybe make more sense (and be safer) that you right-click the rod item onto the stack and not vice versa? There will also need to be some kind of replacement for the rod proficiency bonus, which before was a smelting speed increase. But we should discuss that part on Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the Rod of the Molten Core to use punch rather than holding right click to smelt blocks. This both brings it in line with how the rod of the shifting crust works and improves its usability.