Add getProvidedBlock method to BlockProvider#4959
Open
ChiefArug wants to merge 5 commits intoVazkiiMods:1.20.xfrom
Open
Add getProvidedBlock method to BlockProvider#4959ChiefArug wants to merge 5 commits intoVazkiiMods:1.20.xfrom
ChiefArug wants to merge 5 commits intoVazkiiMods:1.20.xfrom
Conversation
Member
|
What if an item wants to provide multiple types of Blocks? |
Author
|
It can either choose one to return, or simply return The intended usecase of this is for things that can consume any block and so need to be told what block to consume, so changing the return type to a list doesn't make sense for that usecase (the additional entries in the list will just end up being ignored). |
Author
|
Updated the javadoc to better clarify what to do if it can return multiple blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets people determine what a block provider provides without iterating the registry.
My plan for this is compatibility with Tinkers Construct exchanging ability, which replaces mined blocks with the block in the offhand, and adding the ability to provide blocks from things such as the black hole talisman. To replace the block Tinkers needs to know what block its placing.
This is not a breaking change to the API as the method has a default implementation, so the two published addons that implement this interface won't break.