Skip to content

Add a clickable exit button for menu in mobile UI#129

Open
lpmi-13 wants to merge 1 commit intoVictoriaMetrics:masterfrom
lpmi-13:add-exit-button-in-mobile-ui
Open

Add a clickable exit button for menu in mobile UI#129
lpmi-13 wants to merge 1 commit intoVictoriaMetrics:masterfrom
lpmi-13:add-exit-button-in-mobile-ui

Conversation

@lpmi-13
Copy link
Copy Markdown

@lpmi-13 lpmi-13 commented Apr 3, 2026

Describe Your Changes

In a mobile screen, there's no way to easily exit the Graph Settings menu, which takes up the whole screen. Here's what it looks like on the current master branch:

Screenshot from 2026-04-03 21-54-51

This is likely because in the full desktop view, it doesn't take up the entire screen and so it doesn't need a way to be closed. Clicking anywhere else on the page removes focus and it disappears. In order to make the smallest possible change to address this, I've added a small close button, which looks like this in the current commit:

Screenshot from 2026-04-03 22-17-05

If, however, it would be preferable to change this approach so that the menu doesn't take up the entire screen and clicking outside the element removes focus, making it disappear, I can do that instead.

Checklist

The following checks are mandatory:


Summary by cubic

Fixes the mobile Graph Settings menu by showing it as a modal with a close button, so users can exit it. Desktop behavior is unchanged.

Written for commit c404931. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant