Merged
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* comment what code does * add comment about variance * typo
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* initial version * initial version * Enhance copilot onboarding with PR review focus and build system priorities - Strengthen PR review as PRIMARY GOAL across all instruction files - Add visual indicators (🔴🟡🟢) for build system priorities - Emphasize Make as CRITICAL for production builds - Create comprehensive PR review templates and checklists - Streamline examples for quick review scenarios - Add cross-reference navigation improvements - Include quick decision guides for common scenarios - Enhance CI workflow guidance with PR review focus Critical improvements: - Make compatibility is CRITICAL (verify FIRST) - CMake integration is IMPORTANT (verify SECOND) - Bazel testing is DEVELOPMENT (verify THIRD) - PR Review assistance is the PRIMARY goal * Add comprehensive improvement summary document - Document all critical issues resolved - Detail specific improvements implemented - Include quality metrics improvements - Provide expected impact analysis - Outline next steps for validation - Create reference for future improvements * Remove PR_REVIEW_TEMPLATES.md and add comprehensive coding guidelines - Remove PR_REVIEW_TEMPLATES.md file as requested - Create comprehensive coding-guidelines.md based on dev guide analysis - Update README.md to include new coding guidelines file - Enhance general.md with coding standards references - Integrate coding standards into PR review checklists - Ensure consistency across all instruction files New coding guidelines include: - Coding style standards and formatting - Naming conventions for all code elements - Declaration order and class organization - Programming guidelines and best practices - SDL requirements for security and performance - Comments and documentation standards - Comprehensive PR review coding checklist * Remove IMPROVEMENT_SUMMARY.md file as requested * cleaned version * fixing copyrights * fixing copyrights * fixing copyrights * Restructure build-system.md and cleaning license headers * Cleaning headers from AGENTS.md * Adressing comments * Path 2 for context * Cleanup wording * improving docs * Updating local knowledge * fixing links * reducing instructions size * removed extra files * adressing feedback * Adressing comments * adressing code review comments * adressing code review comments * Additions and fixes in daal/AGENTS.md * Additions to cpp/AGENTS.md * Additions to oneapi/AGENTS.md --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Victoriya Fedotova <victoriya.s.fedotova@intel.com>
* Fix insufficient memory allocation in case 0-based oneDAL csr_table to 1-based DAAL CSRNumericTable conversion * Extend testing to cover 0-bazed sparse inputs * Fix a bug in test::engine::csr_table_builder
Fix the logic in convert_to_daal_table(const csr_table & table, bool need_copy): Always do copy the table if need_copy == true. Because otherwise it can lead to crash on GPU.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Support spmd knn search * clang * further restriction of responses logic based on result_options * clang * fix event addition * add queue waits for experimentation * trying without split_table * take 2 * revert debugging * address comment * restore last * debugaboo * further debugging * MORE DEBUG * further debugging * more * shared instead of device * revert last and try wait and throw on copy * trying wait_or_pass * push back events * hotfix: working but suboptimal wait_and_throw in loop * remove debug * minor formatting revisions
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.