Pull changes from UXL main#71
Merged
Vika-F merged 100 commits intoVika-F:dev/distr_ridgefrom Oct 28, 2025
Merged
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* attempt at fix for anaconda * trying conda remove channels * oops * one more attempt * align with sklearnex * restore ci.yml dependsOn * Update .ci/env/apt.sh
* improve precision of composite function * Update cpp/daal/src/algorithms/objective_function/logistic_loss/logistic_loss_dense_default_batch_impl.i * replace loop with call to blas * typo * fix function call * fix signature * fix non-returned value * use correct macro * fix incorrect sum * Update cpp/daal/src/externals/service_blas_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update cpp/daal/src/algorithms/objective_function/logistic_loss/logistic_loss_dense_default_batch_impl.i Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * linter --------- Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com>
* avoid function turning to infinite * replace std calls with mkl * fix syntax * replace calls to MKL with if-elses * match thresholds from dpc version * remove unused import * fix
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Faust <icfaust@gmail.com>
* Add correlation distance algorithm Signed-off-by: North Iii <richard.north.iii@intel.com> * Update with correlation algorithm implementation Signed-off-by: North Iii <richard.north.iii@intel.com> * Add clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com> * Update correlation distance unit test Signed-off-by: North Iii <richard.north.iii@intel.com> * Update correlation_distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com> * Update CPU/GPU correlation distance algorithms Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance_full_impl.i with clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update algo/correlation_distance/BUILD Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance_lp_impl.i * Update cordistance_up_impl.i * Update correlation distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format for daal cordistance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format for cordistance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance_dense_default_batch_fpt_cpu.cpp * Update correlation distance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update examples/oneapi Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance_full_impl.i Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add docs for correlation_distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update clang-format for cordistance_full_impl.i Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add API doc for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Fix docbuild for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Fix docbuild for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update BUILD * Reverted file changes for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Clean up correlation distance changes Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * clang-format updates Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * update clang format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update examples Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update index.rst Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update doc error Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format error Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * DOC: Replace oneAPI logo with UXL (#3109) * replace oneAPI logo with UXL * correct path * Rolled back bazel to 7.4.1 (#3115) * Rolled back bazel to 7.4.1 * Moved back moddule name to Module.bazel. * Rolled for bazel downgrade. * Reverted changes in MODULE.bazel. * Rolled back all of the bazel changes. * Rolled back changes for bazel 8.0.1 * Changed back the substitution version number. * Add information about ittnotify to INSTALL.md (#3118) * Reduce memory requirements of sparse K-means test (#3117) The test that tests SYCL implementation of sparse K-means on the large number of rows was modified: - It was switched off on CPUs; - On all GPUs except Intel(R) Data Center GPU Max series, the number of rows in the testing data set was reduced 100 times to prevent out of memory crashes. * chore(deps): update dependency editorconfig-checker/editorconfig-checker to v3.2.1 (#3121) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [CI, Enhancement] Refine github actions dpcpp linux make build using AVX512 and debug symbols (#3102) * first try * remove false comment * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update makefile * Update makefile * Update makefile * [CI, enhancement] track oneTBB using renovatebot (#3077) * Update renovate.json * Update tbb.sh * Update tbb.bat * Update renovate.json * Update renovate.json * DOC: Remove broken instructions for building with conda environments on windows (#3125) * don't suggest unavailable dos2unix * remove whole broken instructions for conda+windows * Update correlation distance unit test Signed-off-by: North Iii <richard.north.iii@intel.com> * Add clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com> * Update correlation_distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com> * [CI, enhancement] use -fvisibility=hidden in Linux Make builds (#3080) * Update build.sh * Update ci.yml * Update ci.yml * Update ci.yml * Update build.sh * Update test.sh * Update ci.yml * Update test.sh * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update makefile * Update build.sh * Update ci.yml * Update makefile * Update build.sh * Update makefile * Update makefile * Update makefile * Update INSTALL.md * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * add shell script * missing whitespace * spelling mistake * set file permissions * remove unwanted changes * Update abi_check.sh * Update ci.yml * add ignore file * fix CI and shell * swap back * close bracket * spy into variables * fix if statement * change spy improve regex * add suggestions * Update ci.yml * Update ci.yml * Update daal_defines.h * Update makefile * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update common.hpp * Update makefile * Update makefile * Update makefile * Update ci.yml * Update adaboost_predict_dense_default_batch_fpt_cpu.cpp * Update adaboost_predict_dense_default_batch_fpt_cpu.cpp * Update adaboost_train_dense_default_batch_fpt_cpu.cpp * Update adaboost_predict_dense_default_batch_fpt_cpu.cpp * Update adaboost_train_dense_default_batch_fpt_cpu.cpp * Update adaboost_train_dense_default_batch_fpt_dispatcher.cpp * Update compute_types.hpp * fix issues with partial, still leaves decision_tree nodes * remove ONEDAL_EXPORT * return change * further return * fix another implicit instantiation * fix node_info instantiation * Update adaboost_train_dense_default_batch_fpt_dispatcher.cpp * Update adaboost_train_dense_default_batch_fpt_dispatcher.cpp * Update adaboost_train_dense_default_batch_fpt_dispatcher.cpp * Update adaboost_train_dense_default_batch_fpt_dispatcher.cpp * fix stump too * attempt to define some missing things * move namespaces * Update algorithm_container_base_batch.h * Update algorithm_container_base_batch.h * Update ci.yml * Update uniform_dense_default_batch_fpt_dispatcher.cpp * Update normal_dense_default_batch_fpt_dispatcher.cpp * Update bernoulli_dense_default_batch_fpt_dispatcher.cpp * Update bernoulli_dense_default_batch_fpt_dispatcher.cpp * fix engines * intermediate save * formatting * small fix * next batch * missing newline * fix philox * full covariance fixes * first attempt at linear * Update covariance_distributed.h * attempt to fix windows * fixes for windows and elastic net * fix windows issues again * further windows fixes * svm + svd * further windows fixes * more fixes * kernel function solution * fix implicit_als * linear regression changes * low_order_moments * interim save point * further updates * Update sgd_dense_default_batch_fpt_dispatcher.cpp * pca + fixes * passing first examples * final work * attempt to see if this influences missing symbols * Update coordinate_descent_dense_default_batch_fpt_dispatcher.cpp * fix DAAL_EXPORT * clang fixes part 1 * another round of hell * further fixes for clang * fixes on fixes * further fixes for clang * stopping point * fix mistakes * through linear regression * low order moments * naivebayes * DistributedInput will need to be verified throughout the codebase * passing on clang * return SVM change * working oneapi_c examples * additional fixes for dpc tests * pass editor check * remove python3 * last update? * Update common.hpp * updates * Update common.cpp * Update cpu_info_impl.hpp * Update infer_parameters.hpp * Update common.hpp * Update algorithm_container_base_batch.h * Update pca_online.h * conform to daal ABI * conform to daal ABI * begin fixing spmd * fix spmd exports * make fixes for various compiler warnings * try to solve more spmd/ccl issues * try to fix communicator * Update chunked_array_impl.cpp * add spmd related fixes (continued * fix for spmd * Update ci.yml * Update ci.yml * latest fixes * latest fixes * futher fies * further spmd fixes * fix GNU build * attempt again * remove other PR from this one * remove other PR from this one * Update common.hpp * Upgrade to Bazel 8.1.1 (#3120) * Bazel 8.0.1 changes. * Fixed file name. * fixed llvm-ar name. * updated llvm-ar path. * Use llvm-ar tool if found. * Updated to 8.1.1 * Updated format. * Added lines to license. * Added comment. * chore(deps): update actions/upload-artifact action to v4.6.2 (#3132) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency platforms to v0.0.11 (#3133) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency rules_cc to v0.1.1 (#3134) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update naming and dropping Intel specifics (#3116) * Fix outlier detection assignment operators (rule of three violation, Coverity) (#3122) * Update outlierdetection_bacon.cpp * Update outlierdetection_multivariate.cpp * Update outlier_detection_univariate.cpp * Update outlier_detection_bacon_types.h * Update outlier_detection_multivariate_types.h * Update outlier_detection_univariate_types.h * Update outlier_detection_univariate.cpp * Update outlierdetection_multivariate.cpp * Regression algorithm Coverity fixes (rule-of-three violation) (#3127) * Update regression_training_types.h * Update regression_predict_types.h * Update regression_training_input.cpp * Update regression_prediction_batch.cpp * chore(deps): update dependency uxlfoundation/onetbb to v2022 (#3130) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feature(rf optimizations): enabling oneDPL and sort primitive refactoring (#3046) * [bug] fix intermittent failures in LinuxMakeDPCPP(AVX512) github action (#3135) * Update makefile.ver * Update makefile.ver * Update makefile.ver * Update makefile.ver * Update makefile.ver * Update makefile * Update makefile.ver * Update makefile.ver * Update makefile.ver * Update makefile.ver * Update makefile (#3136) * [CI, enhancement] enforce ABI checking of linux DPCPP build (#3112) * first try * remove false comment * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * renew * change permissions * Update abi_check.sh * Update makefile * Update abi_check.sh * Update ci.yml * Update .abignore * Update ci.yml * Update ci.yml * Update ci.yml * Update .ci/scripts/abi_check.sh Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> --------- Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> * remove redundant path (managed by conda) (#3137) * Update abi_check.sh (#3140) * Update CPU/GPU correlation distance algorithms Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Fix rule of three violations in Linear Regression (#3143) Fix rule of three violation in DAAL Linear Regression algorithm and related classes by adding (or marking =delete) the missing copy constructors, copy assignment operators and destructors. * Updated globs for bazel 8.0.0 (#3045) * Removed the noincompatible_disallow_empty_glob flag. * Updated globs. * Allow empty of ccl library. * Removed the empty test. * chore(deps): update dependency uxlfoundation/onetbb to v2022.1.0 (#3145) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [CI, enhancement] set compute runtime GPU settings to improve GPU runner stability (#3146) * Update ci.yml * Update ci.yml * [docs] add missing documentation of gcov support from #3010 (#3147) * Update makefile * Update makefile * Update INSTALL.md * Update INSTALL.md * Update INSTALL.md * Update INSTALL.md * Update makefile * Update INSTALL.md * [fix] add copy assignment operator to quantiles (coverity fix) (#3144) * Update quantiles_types.h * Update quantiles.cpp * [Enhancement] Add float datatype support to rocAucScore (#3074) * Update roc_auc_score.cpp * Update roc_auc_score.cpp * Update roc_auc_score.cpp * Update roc_auc_score.cpp * Update roc_auc_score.h * Update roc_auc_score.cpp * Update roc_auc_score.cpp * clang-formatting and comment * Squashed commit of the following: commit 35e0b62 Author: Faust, Ian <ian.faust@intel.com> Date: Mon Mar 10 14:56:52 2025 +0100 renew commit 1c9299c Author: Ian Faust <icfaust@gmail.com> Date: Mon Mar 10 07:24:21 2025 +0100 Update ci.yml commit c6a7b4a Author: Ian Faust <icfaust@gmail.com> Date: Mon Mar 10 06:44:43 2025 +0100 Update ci.yml commit 18dac73 Author: Ian Faust <icfaust@gmail.com> Date: Thu Mar 6 01:28:24 2025 +0100 Update ci.yml commit d84c663 Author: Ian Faust <icfaust@gmail.com> Date: Thu Mar 6 00:53:40 2025 +0100 Update ci.yml commit 91a523d Author: Ian Faust <icfaust@gmail.com> Date: Thu Mar 6 00:05:02 2025 +0100 Update ci.yml commit a1048df Author: Ian Faust <icfaust@gmail.com> Date: Wed Mar 5 23:54:30 2025 +0100 Update ci.yml commit b6a84b8 Author: Ian Faust <icfaust@gmail.com> Date: Wed Mar 5 23:18:26 2025 +0100 Update ci.yml commit d496c2f Author: Ian Faust <icfaust@gmail.com> Date: Wed Mar 5 22:18:02 2025 +0100 Update ci.yml commit 272fdfe Author: Ian Faust <icfaust@gmail.com> Date: Wed Mar 5 19:15:04 2025 +0100 Update ci.yml commit 05ee213 Author: Ian Faust <icfaust@gmail.com> Date: Wed Mar 5 18:35:28 2025 +0100 Update ci.yml commit fd8bf73 Author: Faust, Ian <ian.faust@intel.com> Date: Wed Mar 5 18:17:24 2025 +0100 remove false comment commit 71c19df Author: Faust, Ian <ian.faust@intel.com> Date: Wed Mar 5 18:10:59 2025 +0100 first try * chmod * Update abi_check.sh * Update makefile * Update roc_auc_score.cpp * Update roc_auc_score.h * Update roc_auc_score.h * Update roc_auc_score.cpp * add ABI fix * Update abi_check.sh * [CI] Update openBLAS to v0.3.29 (#3076) * Update openblas.sh * Update renovate.json * Remove a blank line in modules (#3150) * [enhancement] Add ability to integrate sanitizers in oneDAL Make builds (#3148) * add first attempt * add second attempt * add lopts * add INSTALL.md change * Update makefile * Update INSTALL.md * Update makefile * Update makefile * Update makefile * Update INSTALL.md * Update makefile * change how its used to open up all sanitizers * change wording * change docs again * additional documenation * additional documenation * another english change * add -fno-omit-frame-pointer * Update INSTALL.md Co-authored-by: david-cortes-intel <david.cortes@intel.com> * Update makefile Co-authored-by: david-cortes-intel <david.cortes@intel.com> --------- Co-authored-by: david-cortes-intel <david.cortes@intel.com> * [bugfix] make makefile.ver work with POSIX shells (#3149) * Update makefile.ver * Update makefile.ver * Update CMake version in examples to 3.5 (#3156) * Remove dispatching to SSE2 code path on non-intel x86 CPUs (#3154) * Remove dispatching to sse2 code path on non-intel x86 CPUs * Update minimal cmake version in daal examples to 3.5 * Update minimal cmake version in onedal examples to 3.5 * Fix decision tree coverity hits (#3124) * Update node_info_impl.hpp * Update common.hpp * Fixing new Coverity hits on KNN (#3152) * minor fix * minor fix * FIX: Fix potential non-definitiness of BFGS approximation (#3158) * fix potential non-definitiness on BFGS approximation * correct in more places * DOC: Remove suggestion to use to daal4py in readme (v2) (#3162) * DOC: Remove reference to daal4py * remove link to daal4py examples * add instructions for DPL on conda (#3163) * [CI] Update Windows BaseKit, Windows OpenCL Runtime installs to 2025.1 (#3164) * [bugfix] make shared-libasan default option for ```REQSAN=address``` (#3160) * Update makefile * fix on local testing * ci: add initial AArch64 CI (#3100) * ci: add initial AArch64 CI - Builds openBLAS and tbb. - Builds oneDAL. - Builds examples with static and dynamic linkage. - Executes on GitHub-Hosted Arm runners. - Executes on Arm-Hosted GitHub runners. Signed-off-by: Hamza Butt <hamza.butt@arm.com> * Updates to conform to other CI infrastructure * place oneDAL in the main workspace directory * Update ci-aarch64.yml * revert change * Update apt.sh * Update ci-aarch64.yml * Update ci-aarch64.yml * Update ci-aarch64.yml * Update ci-aarch64.yml * Update ci-aarch64.yml * Update apt.sh * Update apt.sh * Update ci-aarch64.yml * attempt to simplify and restor to OpenBLAS build * fix mistake in label * remove ninja * attempt to fix issues * force timeout on examples due to enable_thread_pinning * try with tbb * try again * abuse the runner to get possible tbb versions * try again * get keys * check intel-tbb * remove checks for tbb --------- Signed-off-by: Hamza Butt <hamza.butt@arm.com> Co-authored-by: Ian Faust <icfaust@gmail.com> * chore(deps): update dependency windows to v2025 (#3165) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update lukka/get-cmake action to v4 (#3166) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * parallelize doc build by default (#3169) * chore(deps): update lukka/get-cmake action to v4.0.1 (#3167) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * DOC: Fix broken link to logreg builder (#3168) * fix broken link * fix formatting * Updated OpenCL dependencies for MKL (#3157) * chore(dev): multiple versions of OpenCL lib for bazel * Work around for opencl issues. --------- Co-authored-by: homksei <aleksei.khomenko@intel.com> * chore(deps): update dependency bazel to v8.2.0 (#3172) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update third-party-program files (#3171) * fix: remove dead code (#3174) * fix: static cast uniqueDepth to int to avoid ull underflow (#3173) * fix: static cast uniqueDepth to int to avoid ull underflow * cast uniqueDepth to int and check overflow * extend to uniqueDepthPartialWeights * fixup * chore(deps): update dependency packaging to v25 (#3179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency bazel to v8.2.1 (#3178) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use aligned loads and stores where possible in DAAL memory management (#3159) * Revert "fix: static cast uniqueDepth to int to avoid ull underflow (#3173)" (#3181) This reverts commit c17ea8b. * update version to 2025.6.0 (#3177) * [CI] swap uxl self-hosted runners to github hosted (#3176) * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * replace cpath (#3183) * fix(docs): Install dependencies fails over debian-installed packages (#3186) * empty commit to trigger doc build * set -euo pipefail * modification in docs to trigger CI * use venv * apt-get update first * revert change to docs/Makefile, only used to trigger docbuild * feature: onedal verbose profiler (#3155) * Revert "[CI] swap uxl self-hosted runners to github hosted (#3176)" (#3188) This reverts commit dace9fb. * cplus_include_path lnx hotfix (#3189) * remove non-applicable footer, update copyright, fix ignored options (#3184) * Update cordistance_full_impl.i with clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update algo/correlation_distance/BUILD Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Use parallel reduce threading primitive in covariance algorithm (#3126) Ads new daal::Reducer interface class that defines the API that have to be implemented in the algorithms to allow the use of reduction primitives based on tbb::parallel_reduce and tbb::parallel_deterministic_reduce. Two new threading primitives were added: threader_reduce implements parallel reduction using dynamic work balancing, static_threader_reduce implements parallel reduction using static work balancing and deterministic reduction. Dense covariance algorithm in oneDAL was modified to use new static_threader_reduce primitive instead of static_threader_for + single thread reduction as it was done previously. tls_data_t structure previously used as a thread local storage for partial results in Covariance algorithm was replaced with CovarianceReduser class which implements the interface of new daal::Reducer to perform parallel reduction. * Fix for copy_without_assign Coverity hits. (#3119) * Fixed the Copy without assign (COPY_WITHOUT_ASSIGN) coverity hit. * chore(deps): update slackapi/slack-github-action action to v2.1.0 (#3193) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency editorconfig-checker/editorconfig-checker to v3.3.0 (#3194) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-python action (#3113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency snowballstemmer to v3 (#3198) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * suggest CPLUS_INCLUDE_PATH instead of CPATH (#3206) * DOC: Correct installation instructions (#3205) * update installation instructions * Update docs/source/get-started/prerequisites.rst Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update docs/source/installation.rst Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update docs/source/installation.rst Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update docs/source/installation.rst Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * use substitutions for library name --------- Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * fix misrendered substitution (#3208) * Fix issues with Logistic Regression and Newton-CG (#3196) * Add debug outputs * Add debug outputs * Fix issues in logloss functior, backtracking algorithm, add tests, remove debug outputs * Clang-format * Minor * Update tolerance, lighten the condition for early-stop in line-search * Improve thread safety in dynamic symbols loading on Windows (#3195) Locally declared static variables are used to get rid of unnecessary checks which might be leading to data races previously. * enh: replace unix2dos with sed (#3210) * [enhancement] Compiler hints for arm (#3141) '#pragma omp simd' is added in place of '#pragma GCC ivdep' compiler hint for GNU in aarch64. This compiler hint boosts DBSCAN, Linear Regression and Ridge Regression by ~10%. --------- Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: Victoriya Fedotova <victoriya.s.fedotova@intel.com> * DOC: Add instructions for executing examples with ASAN (#3207) * add instructions for executing examples with ASAN * Update INSTALL.md * Add grain_size hyperparameter into Covariance and PCA algorithms (#3197) Following changes were made: - API for setting and getting the grain_size efficiency parameter was added into batch Covariance algorithm - API for setting and getting macro_block and grain_size efficiency parameters was added into PCA algorithm with cov method * [CI, enhancement] Switch an arm github actions runner to clang build (#3213) * Update ci-aarch64.yml * Update ci-aarch64.yml * Update ci-aarch64.yml * Update ci-aarch64.yml * fix: use github action instead of gh-pages (#3212) * fix: use github action instead of gh-pages * fix: fix permissions * fix: move permissin and use eaxt commit id for git actions --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * use white logo in dark mode (#3214) * Update cordistance_lp_impl.i * Update cordistance_up_impl.i * Update correlation distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * enh: adding mkl_core deps (#3209) * update version to 2025.7.0 (#3218) * fix: coverity fixes for table and backend functions (#3190) * Fix hyperparameterIdCount in Covariance (#3221) * Update clang-format for daal cordistance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * fix: nightly win issue with profiler(main) (#3222) * Update cordistance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format for cordistance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cordistance_dense_default_batch_fpt_cpu.cpp * Don't need DisableScratchPages with newer version of gpu driver. (#3185) * chore(deps): update lukka/get-cmake action to v4.0.2 (#3215) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Downgrade nightly build to support 22.04 sklearnex testing (#3052) * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * Update nightly-build.yml * [CI] Update apt Linux MKL and DPCPP 2025.1, TBB 2022.1 (#3225) * Update apt.sh * Update apt.sh * Update .abignore * Update correlation distance algo Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update examples/oneapi Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * DOC: Mention oneAPI examples in the build instructions (#3231) * mention oneAPI examples in addition to DAAL * mention DPC examples too * clarify that examples run on sycl devices * Fix: xcsrmv computation wrong arguments (#3236) * print correct version of linter being used (#3233) * Update cordistance_full_impl.i Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add docs for correlation_distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update clang-format for cordistance_full_impl.i Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add API doc for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Fix docbuild for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Fix docbuild for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Add cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update BUILD * Reverted file changes for correlation distance Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Clean up correlation distance changes Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> * Update cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * clang-format updates Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * DOC: Better description of what oneDAL does (#3245) * better description * Update README.md Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update README.md Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> --------- Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * update links (#3244) * Fix architecture typos (#3249) * [CI] prevent some CI jobs from running on forks by default (#3247) * Update ci-aarch64.yml * Update docker-validation-ci.yml * Updated version of CODEOWNERS (#3250) * First iteration of codeowners * Update .github/CODEOWNERS Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> * Update .github/CODEOWNERS Co-authored-by: Anatoly Volkov <117643568+avolkov-intel@users.noreply.github.com> --------- Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Anatoly Volkov <117643568+avolkov-intel@users.noreply.github.com> * chore(deps): update ubuntu:24.04 docker digest to b59d215 (#3239) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ossf/scorecard-action action to v2.4.2 (#3238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency platforms to v1 (#3229) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [CI] remove arm cross compile azure pipelines runners (#3241) * remove arm cross compile azp runners * Delete .ci/env/arm-clang-crosscompile-toolchain.cmake * Delete .ci/env/arm-gnu-crosscompile-toolchain.cmake * chore(deps): update dependency requests to v2.32.4 [security] (#3251) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * remove note about MKL FKP (#3252) * [CI, enhancement] add windows sklearnex azure pipelines template (#3216) * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * ci: add `cve-bin-tool` scan to nightly build (#3204) * ci: add `cve-bin-tool` scan to nightly build * Update .github/workflows/nightly-build.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore(deps): update lukka/get-cmake action to v4.0.3 (#3259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * reset pointer (#3257) * update clang format Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update examples Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update index.rst Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * chore(deps): update dependency urllib3 to v2.5.0 [security] (#3265) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [bugfix] separate stability issues of ```intel/cve-bin-tool-action``` from nightly-build (#3267) * Create nightly-test.yml * Update nightly-test.yml * Update nightly-build.yml * Update nightly-test.yml * Update nightly-test.yml * Update nightly-test.yml * Update nightly-build.yml * Fix Coverity hits in headers (#3192) Following changes were made to fix Coverity hits: - daal::services::internal::Buffer and related APIs were deprecated, as it was only useful in DAAL SYCL APIs that were removed in version 2025.0; - Rule of 3 was fixed in daal::services::Atomic, daal::services::ErrorCollection and daal::services::HostAppIface; - Potential self assignment issue was fixed in SharedPtr. * chore(deps): update doc packages (#3240) * chore(deps): update doc packages * try downgrading sphinx-book-theme * revise sphinx_prompt in extensions --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: ethanglaser <ethan.glaser@intel.com> * chore(deps): update dependency bazel to v8.3.0 (#3268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * ENH: Non-batched route for high-dimensional covariance (#3230) * MAINT: Reuse common routines in covariance (#3227) * reuse common routines * linter * fix sizes for memcpy, restore aligned pragmas * fix * revert missing change * chore(deps): update dependency lxml to v6 (#3272) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * CI jobs for OpenRNG-OpenBLAS-Arm build (#2972) * Added ci jobs for openrng openblas arm build * Modified the build script to enable cross compile * Fixed static link build with openrng backend * Extended exclude list for openrng build Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * excluded more examples Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * revert: externals/service_openrng.h Changes made to service_openrng.h by commit ed04659 breaks the build because the header service_stat_rng_ref.h is not included and the macros present in this file are not compatible with the openrng interface. Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * CI: moved openrng jobs to github workflows Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * CI testing: always pass daal/cpp tests Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * CI arm64-openrng-openblas: set oneapi/cpp examples to always pass Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * typo: changed job name; added comments Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * refactor: address review comments Got rid of unnecessary attributes in class BaseRNG. Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> * documentation: address review comments Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> --------- Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> * [bug] fix shared library AddressSanitizer integration for the gnu compiler (#3256) * Update icx.mkl.32e.mk * Update vc.mkl.32e.mk * Update gnu.mk * Update dpcpp.mk * Update clang.mk * Update makefile * chore(deps): update lukka/get-cmake action to v4.0.3 (#3273) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * adding local_trees mode in RF (#3139) * add bazel support for daal examples (#3235) * chore(deps): update dependency bazel to v8.3.1 (#3277) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency uxlfoundation/onetbb to v2022.2.0 (#3276) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> * Add correlation distance algorithm (#3131) * Adds correlation distance algorithm, examples, docs, and unit tests Signed-off-by: North Iii <richard.north.iii@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update doc error Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update cosine distance algorithm Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * Update clang-format error Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> * add instructions for clang (#3279) * chore(deps): update dependency bazel_skylib to v1.8.0 (#3278) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency rules_cc to v0.1.2 (#3263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update bazel dependency handling for Catch2 and fmt (#3280) * FIX: Initialize pointer to null in topology struct (#3281) * set init pointer to null * disambiguate references to global object and instantiated object * Update ci.yml (#3284) * update version to 2025.8.0 (#3282) * remove bazel http_archive rule (#3286) * [ENH] Read Support for CSR tables in oneapi (#3270) * Added SVE intrinsics for postGemmPart function (#3271) * Added SVE intrinsics for postGemm function * Removed SVE implementation of float exponential due to accuracy issues * Format code using clang-format --------- Co-authored-by: shubham.chaudhari <Shubham.Chaudhari@fujitsu.com> * Update index.rst --------- Signed-off-by: North Iii <richard.north.iii@intel.com> Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com> Signed-off-by: richard.north.iii <rnorthii@smtp.intel.com> Signed-off-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> Signed-off-by: Hamza Butt <hamza.butt@arm.com> Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com> Co-authored-by: richard.north.iii <rnorthii@smtp.jf.intel.com> Co-authored-by: richard.north.iii <rnorthii@smtp.intel.com> Co-authored-by: richard.north.iii <rnorthii@igkmkl802913.igk.intel.com> Co-authored-by: david-cortes-intel <david.cortes@intel.com> Co-authored-by: kmcgrie <Kathleen.mcgrievy@Intel.com> Co-authored-by: Victoriya Fedotova <victoriya.s.fedotova@intel.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Faust <icfaust@gmail.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Aleksandr Solovev <aleksandr.solovev@intel.com> Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: RakshithGB <128027347+rakshithgb-fujitsu@users.noreply.github.com> Co-authored-by: Maria Petrova <maria.petrova@intel.com> Co-authored-by: Hamza <theComputeKid@gmail.com> Co-authored-by: homksei <aleksei.khomenko@intel.com> Co-authored-by: Andreas Huber <9201869+ahuber21@users.noreply.github.com> Co-authored-by: Kamil Jackiewicz <kamil.adam.jackiewicz@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> Co-authored-by: Anatoly Volkov <117643568+avolkov-intel@users.noreply.github.com> Co-authored-by: yuejiaointel <108152493+yuejiaointel@users.noreply.github.com> Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: ethanglaser <ethan.glaser@intel.com> Co-authored-by: Dhanus M Lal <73832063+DhanusML@users.noreply.github.com> Co-authored-by: Khalil <khalil.asadzade02@gmail.com> Co-authored-by: shubhamsvc <117561942+shubhamsvc@users.noreply.github.com> Co-authored-by: shubham.chaudhari <Shubham.Chaudhari@fujitsu.com>
* fix: fix the perf for knn preidction * fix: remove comment
* remove descriptor_base_t * remove issue
* Update apt.sh * Update ci.yml
…stGemmPart function (#3300) * Replace scalar exp with SLEEF SVE float exp for ARM * Add license text * Replace general FP32 scalar exp with SLEEF version in service_math_ref.h * Refactor SVE exp: split loop, and move exp_vectorized out of class * Added more details in License text --------- Co-authored-by: shubham.chaudhari <Shubham.Chaudhari@fujitsu.com>
* fix typo * another typo
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ker to v3.4.0 (#3323) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Alexander Andreev <alexander.andreev@intel.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3389) * Update generate_pkgconfig.py * Update generate_pkgconfig.py
* Update makefile * Update makefile * Update makefile
* check each error code instead of just last * linter * rewrite with classes * remove unused import * remove more unused * remove yet more unused * fix wrong storage * use common error code for oom
* Update vc.mkl.32e.mk * Update makefile * Update makefile * Update nightly-build.yml
* Create pkg-config.cpp * Delete deploy/pkg-config/generate_pkgconfig.py * Delete deploy/pkg-config/pkg-config.tpl * Update makefile * Update makefile * Update makefile * Update makefile * Update makefile * Update makefile * Update makefile * Update makefile * Update makefile * Update ci.yml * Update pkg-config.cpp * Update pkg-config.cpp * Update makefile * Update makefile * Update makefile * Update ci-aarch64.yml * Update INSTALL.md * Update pkg-config.cpp * Update ci.yml * Update apt.sh * Update ci.yml * Update makefile * Update makefile * Update pkg-config.cpp * Update ci.yml * Update makefile * Update makefile * Update makefile
…conda-forge (#3399) * remove unneeded channel * Update INSTALL.md Co-authored-by: Ian Faust <icfaust@gmail.com> --------- Co-authored-by: Ian Faust <icfaust@gmail.com>
…ker to v3.4.1 (#3397) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3394) * fixes for observations with zero weights * consider also zero-weight cases on right branches * Update cpp/daal/src/algorithms/dtrees/forest/regression/df_regression_train_dense_default_impl.i Co-authored-by: Ian Faust <icfaust@gmail.com> * linter * better checks for rightWeights --------- Co-authored-by: Ian Faust <icfaust@gmail.com>
* use fp64 for all random forest aggregates * make compiler happy * linter * rename variables * missing changes
* Initial conda-recipe * Set up Linux conda-build CI job * Revert "Set up Linux conda-build CI job" This reverts commit b172631. * Move CI job to github actions * Fix github action * Fix github action v2 * Split `dal` into different outputs * Fix for dependencies * Update symbolic links and devel package content * TESTING: pytest sklearnex for dal package * Reduce build to AVX2 only * Add compiler variability * Enable compilers matrix for LinuxCondaRecipe CI action * Correct clangxx version * Correct gcc and package versions, set DPL path * Fetch tags for correct conda-build work * Change clangxx version * Change clangxx version * Add examples and remove python testing * Change examples handling * Update devel testing script * Update about:description, devel script and REQCPU handling * Add static examples, fix REQCPU handling * Fix static build issue with conda-forge release of MKL and TBB * Add missing mkl deps for dal-devel testing * FIx mkl deps for dal-devel[dpcpp] * Correct REQCPU default value, TBB runtime dependency and shell type * Remove default libs usage for gnu and clang compilers * Convert test-devel to basic posix format * Update compiler versions * Revert "Remove default libs usage for gnu and clang compilers" This reverts commit 9278cbb. * Remove default libs usage for all compilers * Set default compiler variant * Revert "Remove default libs usage for all compilers" This reverts commit c3a0b38. * Update INSTALL.md * Fix few variables * Change schedule for conda recipe run * Update INSTALL.md Co-authored-by: david-cortes-intel <david.cortes@intel.com> * Add config to CI trigger, change job name Add comment about CONDA_CXX_COMPILER --------- Co-authored-by: david-cortes-intel <david.cortes@intel.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* refactor: remove unused tls_mem template class The tls_mem template class in threading.hpp was never used anywhere in the codebase and contained a known allocator bug (marked with //WRONG comment at line 406). Modern oneDAL uses different memory management patterns: - GPU: ndarray with SYCL USM allocators - CPU: std::vector or dal::array for buffers - Legacy DAAL: Base tls<F> class (without custom allocators) The constructor parameter was previously commented out (line 401), suggesting this class was abandoned during development and became obsolete with architecture evolution. Removing dead code to: - Reduce maintenance burden - Eliminate potential source of confusion - Clean up codebase Verified via grep that no code uses this class. Signed-off-by: AI Assistant <ai@example.com> * fix: remove extra blank line for clang-format compliance Signed-off-by: AI Assistant <ai@example.com> --------- Signed-off-by: AI Assistant <ai@example.com>
Corrects the direction of data copying when resizing the buffer in the collection class and ensures that only the minimum of old and new sizes is copied to prevent buffer overruns.
* chore(deps): update intel-oneapi-apt * Update ci.yml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Faust <icfaust@gmail.com>
- Fix function name typo in array_utils.hpp:46 - Update using declaration in array_utils.hpp:83 - Update function call in table/homogen.hpp:258 Resolves function name spelling error that affects code readability. All 3 references to the misspelled function have been corrected. Fixes #1
* Update nightly-build.yml * Update nightly-build.yml
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Vika-F
requested review from
keeranroth and
rakshithgb-fujitsu
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.