Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive workflow orchestration features to the assignment matcher, including workflow definitions, instance management, event-driven orchestration via Redis Streams, reliability patterns (circuit breaker, DLQ, retries), and a fluent workflow builder DSL.
Key Changes:
- Workflow definition and instance management with versioning support
- Event-driven orchestration using Redis Streams with consumer groups
- Enterprise reliability features (circuit breaker, dead letter queue, idempotency, audit trail)
- Fluent workflow builder DSL for programmatic workflow creation
- OpenTelemetry integration for distributed tracing
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/workflow_manager.test.ts | Comprehensive tests for workflow execution, routing, parallel branches, retries, orchestrator, and reliability features |
| tests/telemetry_manager.test.ts | Tests for OpenTelemetry integration with tracer setup and error handling |
| tests/reliability_manager.test.ts | Tests for DLQ, idempotency, circuit breaker, and audit logging |
| tests/matcher_workflows.test.ts | Integration tests for workflow features through the main Matcher class |
| tests/matcher_pagination.test.ts | Added edge case test for pagination with limit=0 |
| tests/matcher_cidr.test.ts | Added IPv6 edge case tests for CIDR matching |
| src/workflow-builder.ts | Fluent DSL for building workflow definitions programmatically |
| src/managers/WorkflowManager.ts | Core workflow orchestration engine with event processing and Redis Streams |
| src/managers/TelemetryManager.ts | OpenTelemetry wrapper for distributed tracing |
| src/managers/ReliabilityManager.ts | Reliability patterns implementation (DLQ, circuit breaker, idempotency) |
| src/types/matcher.ts | Type definitions for workflows, events, and reliability features |
| src/utils/keys.ts | Redis key builders for workflow-related data structures |
| src/matcher.class.ts | Integration of workflow features into the main Matcher class |
| src/lua/workflow-transition.lua | Lua script for atomic workflow state transitions with optimistic locking |
| src/index.ts | Export workflow types and builder utilities |
| skills.md | Planning document for proficiency-based routing (not implementation) |
| docs/* | Generated API documentation for new types and interfaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.