Skip to content

Update design form lists when research is completed#3838

Open
Monsterovich wants to merge 2 commits intoWarzone2100:masterfrom
Monsterovich:fix-design-form
Open

Update design form lists when research is completed#3838
Monsterovich wants to merge 2 commits intoWarzone2100:masterfrom
Monsterovich:fix-design-form

Conversation

@Monsterovich
Copy link
Contributor

@Monsterovich Monsterovich commented Jun 5, 2024

This PR fixes a small issue: when the research completes, but the item doesn't appear in the list until you manually click on any other of the design parts category buttons (body, propulsion, cannons) and then click back, or re-open the design form completely.

@Monsterovich Monsterovich changed the title Update disign form lists when the research is complete Update design form lists when research is completed Jun 5, 2024
@past-due past-due self-requested a review June 9, 2024 18:22
@past-due past-due added this to the 4.5.0-beta1 milestone Jun 9, 2024
@past-due past-due removed this from the 4.5.0-beta1 milestone Jun 21, 2024
@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
@past-due
Copy link
Member

past-due commented Aug 31, 2025

Unfortunately this section of the UI still uses the old method of creating / refreshing widgets. That method has several disadvantages, but most importantly: it can break the ability to click buttons if they are “refreshed” (which is actually destroying and re-creating) while attempting to do so.

There were previous efforts to rewrite how other sections are handled - such as the production, research, etc side views - to avoid this “difficulty clicking” issue. I’m reluctant to re-introduce this issue to another section (especially when it fixes a fairly small issue, and also - like those other sections - the “trigger” for refreshing is unpredictable to the user, so it ends up creating the same problem where clicks don’t always have an effect).

Additionally, we probably don’t want the order of the displayed buttons to change while the user is attempting to interact with them, which this could also cause.

Given all of that, I think this is best solved by a future rewrite of these widgets to use the new method (which would include handling of when new items might be added while the user is attempting to interact with them - perhaps not even automatically, but with a button that appears and can be clicked to refresh the list).

@Monsterovich
Copy link
Contributor Author

@past-due Is it possible to come up with some kind of temporary solution?

@KJeff01 KJeff01 removed the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants