fix(wasip2): reactors to not export cli/run #708
Draft
+13
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables components to be built without a wasi:cli/run export.
I have a bit of a chicken and egg problem after removing the run export from
defined-symbols.txtwhich seems to be our only test for this. I was able to test by adding additional checks insrc/llvm-project/clang/test/Driver/wasm-toolchain.cbut this wasi-libc change needs to land first for those tests to pass.cc @alexcrichton, there are a number of refactors in flight leading up to #700. No rush on this one, it's something that's bugged me for a while.