Added 'up' and 'down' values for offset option#297
Open
AndClarke wants to merge 2 commits intoWickyNilliams:masterfrom
Open
Added 'up' and 'down' values for offset option#297AndClarke wants to merge 2 commits intoWickyNilliams:masterfrom
AndClarke wants to merge 2 commits intoWickyNilliams:masterfrom
Conversation
| } | ||
|
|
||
| if (currentScrollY <= this.offset ) { | ||
| if (currentScrollY <= this.offset['up'] ) { |
There was a problem hiding this comment.
@AndClarke shouldn't this be this.offset['down']?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very simple update makes offset more powerful. Use case:
offset = 0accomplishes (1) but not (2).offset = NAV_HEIGHTaccomplishes (2) but not (1).With this update you can set
offset = {'up': 0, 'down': NAV_HEIGHT}to accomplish both.