update jQuery plugin to be compatible with ES/CommonJS modules#334
Open
WickyNilliams wants to merge 4 commits intomasterfrom
Open
update jQuery plugin to be compatible with ES/CommonJS modules#334WickyNilliams wants to merge 4 commits intomasterfrom
WickyNilliams wants to merge 4 commits intomasterfrom
Conversation
37650e7 to
3b6decd
Compare
Owner
Author
|
Added a tests for jquery, and refactored the test suite so we can run the exact same set of tests for vanilla and jquery solutions. |
Owner
Author
|
I'm considering bundling Headroom with the jquery plugin itself, so the above code sample would be reduced to a much less boilerplate-y: import $ from "jquery";
import registerJQueryHeadroom from "headroom.js/dist/jQuery.headroom.js";
registerJQueryHeadroom($);
$("header").headroom(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, the following should be possible: