UnslashingFunctionsHelper::is_unslashing_function(): add tests#2715
Open
rodrigoprimo wants to merge 2 commits intoWordPress:developfrom
Open
UnslashingFunctionsHelper::is_unslashing_function(): add tests#2715rodrigoprimo wants to merge 2 commits intoWordPress:developfrom
rodrigoprimo wants to merge 2 commits intoWordPress:developfrom
Conversation
jrfnl
approved these changes
Apr 1, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
LGTM.
I presume you have verified that there are no stray @covers tags for this function in pre-existing tests ?
Collaborator
Author
|
Thanks for your review, @jrfnl!
Yes, I have, and there are no stray |
Remove trailing `()` from the `@covers` tag and reorder `@see` to come before `@return`.
Collaborator
Author
|
I pushed a new commit to this PR addressing two minor issues that I noticed while working on a similar PR:
|
Member
|
@rodrigoprimo Yes, I noticed what you mention in the second bullet (also in #2713) and the way it is now is definitely preferred, but it was not a blocker. Good catch on the first. I missed that. |
Member
|
For whomever does the second review: please squash-merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for supporting PHPCS 4.0, this PR adds unit tests for the
UnslashingFunctionsHelper::is_unslashing_function()method.Suggested changelog entry
N/A