Skip to content

fix(frontend): prevent back-to-top button overlapping footer (#4966) #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shekhar0109 wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −13
Open

fix(frontend): prevent back-to-top button overlapping footer (#4966) #5537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
681960e
fix(frontend): prevent back-to-top button overlapping footer (#4966)
Shekhar0109 Dec 3, 2025
e6f039b
chore: fix prettier formatting
Shekhar0109 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/VScrollButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const scrollToTop = () => {
<button
:aria-label="$t('browsePage.aria.scroll')"
type="button"
class="scroll fixed bottom-4 mb-4 ms-auto h-14 w-14 rounded-full bg-primary text-center text-over-dark transition-all duration-100 ease-linear hover:bg-primary-hover hover:shadow-md"
class="scroll sticky bottom-4 mb-4 ms-auto h-14 w-14 rounded-full bg-primary text-center text-over-dark transition-all duration-100 ease-linear hover:bg-primary-hover hover:shadow-md"
:class="hClass"
@click="scrollToTop"
@keydown.tab.exact="$emit('tab', $event)"
Expand Down
13 changes: 7 additions & 6 deletions frontend/src/layouts/content-layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,15 @@ provide(ShowScrollButtonKey, showScrollButton)

<div class="main-page flex h-full w-full min-w-0 flex-col justify-between">
<slot />

<VScrollButton
v-show="showScrollButton"
:is-filter-sidebar-visible="false"
data-testid="scroll-button"
/>

<VFooter mode="internal" class="border-t border-default bg-default" />
</div>

<VScrollButton
v-show="showScrollButton"
:is-filter-sidebar-visible="false"
data-testid="scroll-button"
/>
</div>
</template>

Expand Down
13 changes: 7 additions & 6 deletions frontend/src/layouts/search-layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,15 @@ provide(ShowScrollButtonKey, showScrollButton)
class="main-page flex h-full w-full min-w-0 flex-col justify-between overflow-y-auto"
>
<slot />

<VScrollButton
v-show="showScrollButton"
:is-filter-sidebar-visible="isSidebarVisible"
data-testid="scroll-button"
/>

<VFooter mode="content" class="border-t border-default bg-default" />
</div>

<VScrollButton
v-show="showScrollButton"
:is-filter-sidebar-visible="isSidebarVisible"
data-testid="scroll-button"
/>
</div>
</template>

Expand Down