Skip to content

DOC-18493 Internationalize the date and time string#208

Merged
btr-rmconsole-5[bot] merged 1 commit intomasterfrom
intl-date-and-time-string
Jan 26, 2026
Merged

DOC-18493 Internationalize the date and time string#208
btr-rmconsole-5[bot] merged 1 commit intomasterfrom
intl-date-and-time-string

Conversation

@jacobfeddersen-wf
Copy link
Contributor

@jacobfeddersen-wf jacobfeddersen-wf commented Jan 16, 2026

Motivation

Internationalize the date and time string. Really this is just internationalizing the comma between the parts.

Changes

We previously internationalized the Yesterday and Today messages. The date and time string is already using intl methods to format the date and time portions of the string, but is using a static ${date}, ${time} composition to combine them. Move that string to a parameterized internationalization string.

This may not actually be necessary, but my understanding is that not all languages would necessarily use the same punctuation to combine these two parts.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@jacobfeddersen-wf jacobfeddersen-wf changed the title Internationalize the date and time string DOC-18493 Internationalize the date and time string Jan 16, 2026
@jacobfeddersen-wf jacobfeddersen-wf marked this pull request as ready for review January 16, 2026 17:10
@jacobfeddersen-wf jacobfeddersen-wf added the Hold Hold merges label Jan 16, 2026
@jacobfeddersen-wf jacobfeddersen-wf removed the Hold Hold merges label Jan 26, 2026
@nathanielward-wk
Copy link

QA +1
Ci Passing

@nathanielward-wk
Copy link

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-5 btr-rmconsole-5 bot merged commit b9f8233 into master Jan 26, 2026
5 checks passed
@btr-rmconsole-5 btr-rmconsole-5 bot deleted the intl-date-and-time-string branch January 26, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants