fix: format number value from string first#52
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where numeric values stored as strings in the database were causing errors when methods like .toFixed() were called on them. The fix adds explicit Number() conversions before using these string values in arithmetic operations or calling number methods on them.
Changes:
- Added
formatparameter togetAverageMetricmethod inmetric.jsto convert string values to numbers before processing - Added
format: value => Number(value)functions to various metric key configurations in service files - Added explicit
Number()conversions in controller files before calling.toFixed()on numeric values
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/service/metric.js | Added format parameter to getAverageMetric method and applied it to metric values before processing |
| app/service/system.js | Added format functions to osCpuTrend, loadTrend, and httpResponseTrend metric keys |
| app/service/process.js | Added format functions to all cpuTrend metric keys (cpu_now, cpu_15, cpu_30, cpu_60) |
| app/controller/system.js | Added Number() conversions for used_cpu, used_memory_percent, load values, and http_rt before using toFixed() |
| app/controller/process.js | Added Number() conversion for cpu_60 before calling toFixed() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes X-Profiler/all-in-one#7 #50