fix: Don't cache responses to admin's requests#3058
Open
kuznetsss wants to merge 2 commits intoXRPLF:developfrom
Open
fix: Don't cache responses to admin's requests#3058kuznetsss wants to merge 2 commits intoXRPLF:developfrom
kuznetsss wants to merge 2 commits intoXRPLF:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3058 +/- ##
===========================================
- Coverage 81.89% 81.88% -0.02%
===========================================
Files 396 396
Lines 15898 15900 +2
Branches 8432 8433 +1
===========================================
Hits 13019 13019
- Misses 1671 1673 +2
Partials 1208 1208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
requested changes
May 1, 2026
|
|
||
| auto const cmd = boost::json::value_to<std::string>(request.at("command")); | ||
| if (forwardingCache_) { | ||
| if (forwardingCache_ and not isAdmin) { |
Collaborator
There was a problem hiding this comment.
You should probably use new method shouldUseCache here and in the next diff :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.