fix: assertion failure in JobQueue::stop
#5774
Draft
Codecov / codecov/project
succeeded
Apr 5, 2026 in 1s
79.9% (target 75.0%)
View this Pull Request on Codecov
79.9% (target 75.0%)
Details
Codecov Report
❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (fe9c8d5) to head (02793cd).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| include/xrpl/core/Coro.ipp | 95.0% | 2 Missing |
| src/libxrpl/core/detail/JobQueue.cpp | 87.5% | 2 Missing |
| include/xrpl/core/JobQueue.h | 87.5% | 1 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## develop #5774 +/- ##
=========================================
- Coverage 79.9% 79.9% -0.0%
=========================================
Files 839 840 +1
Lines 65528 65582 +54
Branches 7273 7267 -6
=========================================
+ Hits 52330 52373 +43
- Misses 13198 13209 +11 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/core/JobQueue.h | 90.9% <87.5%> (-9.1%) |
⬇️ |
| include/xrpl/core/Coro.ipp | 94.8% <95.0%> (-5.2%) |
⬇️ |
| src/libxrpl/core/detail/JobQueue.cpp | 90.3% <87.5%> (-0.5%) |
⬇️ |
... and 438 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading