fix: Move AMMInvariant weakInvariantCheck logic into the transaction

[Kassaking7]

High Level Overview of Change

Move AMMInvariant weakInvariantCheck logic into the transaction to mitigate the error code to tecPRECISSION_LOSS instead of tecINVARIANT_FAILED.

Context of Change

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (46b997b) to head (32ccbf6).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #7032     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        75961   75986     +25     
  Branches      7392    7382     -10     
=========================================
+ Hits         62330   62348     +18     
- Misses       13631   13638      +7     

Files with missing lines	Coverage Δ
include/xrpl/ledger/helpers/AMMHelpers.h	96.1% <ø> (ø)
src/libxrpl/ledger/helpers/AMMHelpers.cpp	95.7% <100.0%> (+0.1%)	⬆️
src/libxrpl/tx/invariants/AMMInvariant.cpp	95.0% <ø> (ø)
src/libxrpl/tx/transactors/dex/AMMClawback.cpp	98.7% <100.0%> (+<0.1%)	⬆️
src/libxrpl/tx/transactors/dex/AMMDeposit.cpp	96.1% <100.0%> (+<0.1%)	⬆️
src/libxrpl/tx/transactors/dex/AMMWithdraw.cpp	94.6% <100.0%> (+0.1%)	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Tapanito]

/ai-review

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[github-actions]

This PR has conflicts, please resolve them in order for the PR to be reviewed.

[github-actions]

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

[Kassaking7]

/ai-review

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[github-actions]

This PR has conflicts, please resolve them in order for the PR to be reviewed.

[godexsoft]

We recently merged a refactor to develop that enables clang-tidy's readability-identifier-naming. Your branch now has heavy conflicts that are largely mechanical. Below is a workflow that aligns your branch's naming with develop before merging, which should minimize the merge conflicts.

One-time setup

If you don't already have clang-tidy working in your env, on macOS:

brew install llvm@21
# Follow brew's hint to put $(brew --prefix llvm@21)/bin on PATH so run-clang-tidy is found.

Workflow on your branch (before merging develop)

1. Grab the new .clang-tidy from develop without pulling anything else. Sync your fork on GitHub first, then:

git remote -v   # should show 'upstream' among others; if not:
# git remote set-url upstream git@github.com:XRPLF/rippled.git
git fetch upstream
git checkout upstream/develop -- .clang-tidy

2. Reconfigure conan/cmake so compile_commands.json is fresh.

3. Apply renames for the files modified in your PR:

git diff --name-only $(git merge-base HEAD upstream/develop) HEAD \
  | grep -E '\.(cpp|h|hpp|ipp)$' \
  | xargs run-clang-tidy -p build -fix -allow-no-checks
# or -p .build, or whatever your build dir is called

4. Build + test, then commit as a single dedicated commit:

cmake --build build -j8
git commit -am "refactor: Align identifier naming with develop"

5. Now merge develop:

git merge upstream/develop

Extra

Run clang-tidy once more after the merge to catch any stragglers introduced from develop's side:

run-clang-tidy -p build -fix -allow-no-checks src tests
# or -p .build, or whatever your build dir is called