fix: Add defensive check for permission to tx type cast#7047
Open
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
Open
fix: Add defensive check for permission to tx type cast#7047yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
Conversation
e52e731 to
a7c33e2
Compare
a7c33e2 to
4513859
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7047 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.0%
=========================================
Files 1010 1010
Lines 75961 75965 +4
Branches 7392 7383 -9
=========================================
- Hits 62330 62325 -5
- Misses 13631 13640 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
permissionToTxType,values outside this range would silently truncate when cast to
uint16_t, for example, 65537 would become 1, mapping to the Payment transaction.
(Might have some overlap with #6613. but keeping it as a separate PR for clearer scope, review and tracking.)
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)