Remove some float hostfunctions#7053
Remove some float hostfunctions#7053oleks-rip wants to merge 2 commits intoXRPLF:ripple/wasmi-host-functionsfrom
Conversation
remove floatAbs remove floatNegate remove floatLog
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #7053 +/- ##
=============================================================
- Coverage 82.0% 82.0% -0.0%
=============================================================
Files 1025 1025
Lines 78213 78105 -108
Branches 7662 7656 -6
=============================================================
- Hits 64155 64051 -104
+ Misses 14058 14054 -4
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I think we agreed to use |
|
|
||
| struct WasmImportFunc | ||
| { | ||
| std::string name; |
There was a problem hiding this comment.
These changes seem unrelated, what are they for?
There was a problem hiding this comment.
to not make a copy of names. So this one and unordered_map<**std::string_view**, WasmUserData> ImportVec; will point to the same data
renamed 829de99 |
| if (importTypes.empty()) | ||
| return {}; | ||
| if (imports.empty()) | ||
| throw std::runtime_error("Missing imports"); |
3 participants
High Level Overview of Change
flotSet -> floatFromMantissaAndExponent
remove floatAbs
remove floatNegate
remove floatLog