Skip to content

feat: Pull Logger from Clio and add structured logging #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
a1q123456 wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft

feat: Pull Logger from Clio and add structured logging #7055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a41704b
Add spdlog to xrpld
a1q123456 Apr 23, 2026
17c7398
Update conan lock
a1q123456 Apr 23, 2026
cd94d7d
Add Logger from clio and implement json logging
a1q123456 Apr 29, 2026
06193bd
Performance improvements
a1q123456 Apr 29, 2026
d1f6d4f
Optimisation
a1q123456 Apr 30, 2026
a3f8e8f
Add functionality to extend the context data
a1q123456 Apr 30, 2026
6897a85
Cleanup the code
a1q123456 Apr 30, 2026
640c90e
Fix clang-tidy errors
a1q123456 Apr 30, 2026
5c01da5
Improve test coverage
a1q123456 May 1, 2026
f1305dc
Fix clang tidy errors
a1q123456 May 1, 2026
ed7a936
Fix errors
a1q123456 May 1, 2026
ed15220
fix clang-tidy errors
a1q123456 May 1, 2026
9135171
Improve test coverage
a1q123456 May 1, 2026
2e76861
Fix clang-tidy errors
a1q123456 May 1, 2026
418f670
Fix clang-tidy erros
a1q123456 May 1, 2026
b70c1f9
Merge branch 'develop' into a1q123456/spd-log-from-clio
a1q123456 May 1, 2026
3f1cb05
Fix errors
a1q123456 May 1, 2026
c9cf78f
Improve test coverage
a1q123456 May 1, 2026
3f7b2ae
Remove unneeded include directive in Logger.cpp
a1q123456 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ find_package(secp256k1 REQUIRED)
find_package(SOCI REQUIRED)
find_package(SQLite3 REQUIRED)
find_package(xxHash REQUIRED)
find_package(spdlog REQUIRED)

target_link_libraries(
xrpl_libs
Expand Down
1 change: 1 addition & 0 deletions cmake/XrplCore.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ target_link_libraries(
secp256k1::secp256k1
xrpl.libpb
xxHash::xxhash
spdlog::spdlog
$<$<BOOL:${voidstar}>:antithesis-sdk-cpp>
)

Expand Down
6 changes: 4 additions & 2 deletions conan.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,23 @@
"zlib/1.3.1#cac0f6daea041b0ccf42934163defb20%1774439233.809",
"xxhash/0.8.3#681d36a0a6111fc56e5e45ea182c19cc%1765850149.987",
"sqlite3/3.51.0#66aa11eabd0e34954c5c1c061ad44abe%1774467355.988",
"spdlog/1.17.0#bcbaaf7147bda6ad24ffbd1ac3d7142c%1768312128.781",
"soci/4.0.3#fe32b9ad5eb47e79ab9e45a68f363945%1774450067.231",
"snappy/1.1.10#968fef506ff261592ec30c574d4a7809%1765850147.878",
"secp256k1/0.7.1#481881709eb0bdd0185a12b912bbe8ad%1770910500.329",
"rocksdb/10.5.1#4a197eca381a3e5ae8adf8cffa5aacd0%1765850186.86",
"re2/20251105#8579cfd0bda4daf0683f9e3898f964b4%1774398111.888",
"protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1774467363.12",
"openssl/3.6.1#e6399de266349245a4542fc5f6c71552%1774458290.139",
"nudb/2.0.9#11149c73f8f2baff9a0198fe25971fc7%1774883011.384",
"nudb/2.0.9#11149c73f8f2baff9a0198fe25971fc7%1775040983.408",
"lz4/1.10.0#59fc63cac7f10fbe8e05c7e62c2f3504%1765850143.914",
"libiconv/1.17#1e65319e945f2d31941a9d28cc13c058%1765842973.492",
"libbacktrace/cci.20210118#a7691bfccd8caaf66309df196790a5a1%1765842973.03",
"libarchive/3.8.1#ffee18995c706e02bf96e7a2f7042e0d%1765850144.736",
"jemalloc/5.3.0#e951da9cf599e956cebc117880d2d9f8%1729241615.244",
"jemalloc/5.3.0#c671e612af76700db5957c9857978a1c%1776700030.961",
"gtest/1.17.0#5224b3b3ff3b4ce1133cbdd27d53ee7d%1768312129.152",
"grpc/1.78.1#b1a9e74b145cc471bed4dc64dc6eb2c1%1774467387.342",
"fmt/12.1.0#50abab23274d56bb8f42c94b3b9a40c7%1763984116.926",
"ed25519/2015.03#ae761bdc52730a843f0809bdf6c1b1f6%1765850143.772",
"date/3.0.4#862e11e80030356b53c2c38599ceb32b%1765850143.772",
"c-ares/1.34.6#545240bb1c40e2cacd4362d6b8967650%1774439234.681",
Expand Down
3 changes: 3 additions & 0 deletions conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class Xrpl(ConanFile):
"openssl/3.6.1",
"secp256k1/0.7.1",
"soci/4.0.3",
"spdlog/1.17.0",
"zlib/1.3.1",
]

Expand Down Expand Up @@ -109,6 +110,7 @@ class Xrpl(ConanFile):
"secp256k1/*:shared": False,
"snappy/*:shared": False,
"soci/*:shared": False,
"spdlog/*:shared": False,
"soci/*:with_sqlite3": True,
"soci/*:with_boost": True,
"xxhash/*:shared": False,
Expand Down Expand Up @@ -213,6 +215,7 @@ def package_info(self):
"protobuf::libprotobuf",
"soci::soci",
"secp256k1::secp256k1",
"spdlog::spdlog",
"sqlite3::sqlite",
"xxhash::xxhash",
"zlib::zlib",
Expand Down
Loading
Loading