Skip to content

Refactor to only have one metadata model#110

Closed
LimpidCrypto wants to merge 1 commit intodevfrom
refactor/only-one-metadata
Closed

Refactor to only have one metadata model#110
LimpidCrypto wants to merge 1 commit intodevfrom
refactor/only-one-metadata

Conversation

@LimpidCrypto
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

The last release included a duplicate of the TransactionMetadata model. I removed the one in the results module as the one in transaction is stronger typed. I added some missing fields to the model and the documentation. I also added the test of the result module and made sure it passes.

Type of Change

  • Refactor (non-breaking change that only restructures code)

@LimpidCrypto LimpidCrypto requested a review from sephynox March 1, 2025 15:07
@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Mar 1, 2025
@LimpidCrypto LimpidCrypto self-assigned this Mar 1, 2025
@e-desouza
Copy link
Copy Markdown
Collaborator

e-desouza commented Mar 28, 2026

Closing this since dev doesn't exist anymore. Opened #153 against main — same idea, one TransactionMetadata instead of two. Also typed DeliveredAmount (handles the "unavailable" string from old partial payments), AffectedNode variants, and NFToken/MPToken fields while I was in there. Thanks for flagging the duplication originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants