Support for DID feature in xrpl-rust#161
Open
ckeshava wants to merge 4 commits intoXRPLF:mainfrom
Open
Conversation
Collaborator
Author
|
/ai-review |
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
| /// Maximum length in hex characters for DID fields (Data, DIDDocument, URI). | ||
| /// Each field is limited to 256 bytes, which is 256 hex characters in | ||
| /// the client library convention (matching xrpl-py). | ||
| pub const MAX_DID_FIELD_LENGTH: usize = 256; |
There was a problem hiding this comment.
Off-by-2x: 256 bytes = 512 hex chars, not 256. This rejects valid 129–256 byte DID fields. Also fix the doc comment above:
/// Maximum length in hex characters for DID fields (Data, DIDDocument, URI).
/// Each field is limited to 256 bytes, which is 512 hex characters
/// (1 byte = 2 hex chars; matching xrpl-py if it's correct).
pub const MAX_DID_FIELD_LENGTH: usize = 512;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
As indicated by the title, this PR adds support for DID amendment in xrpl-rust.
Context of Change
Two new transactions DIDSet and DIDDelete have been introduced. No new RPCs (or) updates to the binary-codec are included as a part of this change.
Type of Change
Test Plan
Additional unit and integration tests have been included to validate the DID-related behavior.