Open
Conversation
* Add NFT_OFFER to AccountObjectsRequestParams * Rearrange enum values (alphabetical order) * Add unit test coverge for all enum values * Improve JSON unit test coverage for NfTokenOfferObject * Subsumes PR #545 Signed-off-by: David Fuelling <sappenin@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
=========================================
Coverage 92.74% 92.74%
Complexity 2276 2276
=========================================
Files 460 460
Lines 5942 5943 +1
Branches 480 480
=========================================
+ Hits 5511 5512 +1
Misses 279 279
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Left a line for tracking |
Patel-Raj11
approved these changes
May 4, 2026
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.google.common.primitives.UnsignedInteger; | ||
| import com.google.common.primitives.UnsignedLong; |
Collaborator
There was a problem hiding this comment.
UnsignedLong is added as an import but I don't see it used anywhere in this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit to @psy2848048 for instigating this fix via #545