fix: remove 5.x support and update decode method signature#327
Open
jasonlewis wants to merge 1 commit intoXeroAPI:feature/sdk-automationfrom
Open
fix: remove 5.x support and update decode method signature#327jasonlewis wants to merge 1 commit intoXeroAPI:feature/sdk-automationfrom
jasonlewis wants to merge 1 commit intoXeroAPI:feature/sdk-automationfrom
Conversation
philiphoek
approved these changes
Sep 6, 2023
|
I have also run into this problem, so it would be nice if this can be released as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See advisory: Firebase PHP-JWT key/algorithm type confusion
There's also an issue where the two versions of jwt-php have different method signatures for the
JWT::decodemethod. In version 6 supported algorithms are no longer given as a third parameter.JWK::parseKeySetalready returns a properly formatted array of keys.https://github.com/firebase/php-jwt/tree/main#using-jwks