change the small deformation to finite deformation.#540
Open
rukawaaaaaaa wants to merge 3 commits intomasterfrom
Open
change the small deformation to finite deformation.#540rukawaaaaaaa wants to merge 3 commits intomasterfrom
rukawaaaaaaa wants to merge 3 commits intomasterfrom
Conversation
Xiangyu-Hu
requested changes
Mar 7, 2024
Owner
Xiangyu-Hu
left a comment
Xiangyu-Hu
left a comment
There was a problem hiding this comment.
Could you put a new test case with regression data for the new features? Thanks.
DongWuTUM
reviewed
Mar 12, 2024
| dangular_vel_dt_[index_i] = getRotationFromPseudoNormalForSmallDeformation( | ||
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(local_dpseudo_n_d2t), Vec3d(rotation_[index_i]), Vec3d(angular_vel_[index_i]), dt); | ||
| dangular_b_vel_dt_[index_i] = getRotationFromPseudoNormalForFiniteDeformation_b( | ||
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(rotation_b_[index_i]), Vec3d(angular_b_vel_[index_i]), dt); |
Collaborator
There was a problem hiding this comment.
Here, Vec3d is not needed, since the slender structure simulation is always 3D.
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(local_dpseudo_n_d2t), Vec3d(rotation_[index_i]), Vec3d(angular_vel_[index_i]), dt); | ||
| dangular_b_vel_dt_[index_i] = getRotationFromPseudoNormalForFiniteDeformation_b( | ||
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(rotation_b_[index_i]), Vec3d(angular_b_vel_[index_i]), dt); | ||
| dangular_vel_dt_[index_i] = getRotationFromPseudoNormalForFiniteDeformation( |
Collaborator
There was a problem hiding this comment.
Please notice the writing, thanks:) Two more spaces here.
| (rotation_1_b1 * rotation_1_b1 + rotation_1_b2 * rotation_1_b2 + Eps); | ||
|
|
||
| return Vec3d(angle_vel_dt_0, angle_vel_dt_1, 0.0); | ||
| return Vec3d(0, angle_vel_dt_1, 0.0); |
Collaborator
There was a problem hiding this comment.
For writing consistency, 0.0 should be here.
| 2.0 * angular_b_vel[0] * angular_b_vel[2] * sin_rotation_b_2 * sin_rotation_b_0 * cos_rotation_b_0; | ||
|
|
||
| Real angle_b_vel_dt_2 = rotation_b_c * rotation_b_c * (rotation_b_c1 * cos_rotation_b_2 + rotation_b_c2 * sin_rotation_b_2) / (rotation_b_c1 * rotation_b_c1 + rotation_b_c2 * rotation_b_c2 + Eps); | ||
| return Vec3d(0, 0.0, angle_b_vel_dt_2); |
| Real rotation_0_b = sin_rotation_0 * angular_vel[0] * angular_vel[0] - dpseudo_n_d2t[1]; | ||
| Real angle_vel_dt_0 = sin_rotation_0 * rotation_0_a + cos_rotation_0 * rotation_0_b; | ||
|
|
||
| */ |
Collaborator
There was a problem hiding this comment.
These comments can be deleted now.
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(local_dpseudo_n_d2t), Vec3d(rotation_b_[index_i]), Vec3d(angular_b_vel_[index_i]), dt); | ||
| dangular_vel_dt_[index_i] = getRotationFromPseudoNormalForSmallDeformation( | ||
| Vec3d(local_dpseudo_b_n_d2t), Vec3d(local_dpseudo_n_d2t), Vec3d(rotation_[index_i]), Vec3d(angular_vel_[index_i]), dt); | ||
| dangular_b_vel_dt_[index_i] = getRotationFromPseudoNormalForFiniteDeformation_b( |
Collaborator
There was a problem hiding this comment.
Since this pull request focuses on Finite Deformation/Rotation, could you add a test case with a large rotation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The small deformation is replaced by fintie deformation. Now the beam can be defromed in any direction with the rotation large than pi/2