Fix speed of sound calculation for elastic solids#688
Open
FabienPean-Virtonomy wants to merge 2 commits intomasterfrom
Open
Fix speed of sound calculation for elastic solids#688FabienPean-Virtonomy wants to merge 2 commits intomasterfrom
FabienPean-Virtonomy wants to merge 2 commits intomasterfrom
Conversation
Xiangyu-Hu
approved these changes
Nov 22, 2024
Collaborator
Author
|
This fix triggers (regression) failure for all those cases: I will leave it to you from here @Xiangyu-Hu |
Owner
|
@FabienPean-Virtonomy It seems that we need update the regression test data set the failures are due to mismatched data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
ElasticSolidclass in thesrc/shared/materials/elastic_solid.cppfile. The change modifies the calculation of the sound speeds to ensure accuracy for three-dimensional solids.The pressure wave speed for isotropic elastic solids is (see Wikipedia)